Remove JS autoFocus implementation #27923
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
janicduplessis
force-pushed
the
autofocus-native-2
branch
from
6749fd2
to
3ba7ac2
Compare
janicduplessis
changed the title
|
Remind me to land this on February 10th |
|
Ping! @TheSavior |
|
Thanks for the ping! Looks like I can't land this yet. Let's check again on 2/17! 😀 |
|
I'M a bot 😆 Ping! @TheSavior |
|
😄 thanks @ecreeth |
|
Thanks for the pings! |
facebook-github-bot
approved these changes
Feb 18, 2020
There was a problem hiding this comment.
@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @janicduplessis in 0569d4c. When will my fix make it into a release? | Upcoming Releases |
|
Yay! |
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: Follow up to facebook#27803 and facebook#27924. We no longer need to call focus on mount from JS as both iOS and Android implements it natively now. ## Changelog [General] [Fixed] - Remove JS autoFocus implementation Pull Request resolved: facebook#27923 Test Plan: Test that focus works in RN Tester with this, facebook#27803 and facebook#27924 Differential Revision: D19956373 Pulled By: TheSavior fbshipit-source-id: 5d99ead55011663b3edaf499ac7616765a24cb50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #27803 and #27924. We no longer need to call focus on mount from JS as both iOS and Android implements it natively now.
Changelog
[General] [Fixed] - Remove JS autoFocus implementation
Test Plan
Test that focus works in RN Tester with this, #27803 and #27924