Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix For Android Device Connection To Firestore #17449

Closed
wants to merge 4 commits into from
Closed

Fix For Android Device Connection To Firestore #17449

wants to merge 4 commits into from

Commits on Jan 3, 2018

  1. Setting ANDROID_LONG_TIMER_MESSAGE to '(ADVICE)' 

    This commit is based on a suggestion made by a Firebase member facebook#17083.
Longer timers are used in critical parts of Firebase-SDK such as refreshing the token; Its a bad user experience if the token expires and users need to keep login to the application! We appreciate your cooperation.
    @samsafay
    samsafay authored Jan 3, 2018
    Configuration menu
    Copy the full SHA
    efddf1d View commit details
    Browse the repository at this point in the history

  2. Checking For the GET or HEAD in send method 

    The following change is suggested by a Firebase member here. firebase/firebase-js-sdk#283
It follows the whatwg.org's send method guidelines. https://xhr.spec.whatwg.org/#dom-xmlhttprequest-send
At the section 3 of 4.5.6, it is suggests to check for the GET or HEAD methods, for every XMLHttpRequest send() method, then set the body to null if it is true.
    @samsafay
    samsafay authored Jan 3, 2018
    Configuration menu
    Copy the full SHA
    a55fe37 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2018

  1. Update NetworkingModule.java

    @samsafay
    samsafay authored Jan 4, 2018
    Configuration menu
    Copy the full SHA
    c463c72 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2018

  1. rebase the fork

    @samsafay
    samsafay committed Feb 11, 2018
    Configuration menu
    Copy the full SHA
    833c0ce View commit details
    Browse the repository at this point in the history