Run eslint --fix #16229
Closed
Run eslint --fix #16229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janicduplessis
requested review from
grabbou,
hramos and
Kureev
as code owners
facebook-github-bot
added
the
CLA Signed
|
CI still fails but at least one step further on flow metro bundler problems :) |
|
One step closer to getting done #15726 |
|
@TheSavior Could you ship this, looks like you were the last one to play with lint stuff :) |
|
I have submitted #16259 which is slightly smaller than this PR and needed it to release new RC |
|
Wish I saw this PR earlier before struggling to understand why my build has
failed. Thanks Janic!
…On Sat, 7 Oct 2017 at 03:45 Janic Duplessis ***@***.***> wrote:
@TheSavior <https://github.com/thesavior> Could you ship this, looks like
you were the last one to play with lint stuff :)
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#16229 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACWcxvrHSz5B4upPct1XMBH5PH-8kYkvks5spte1gaJpZM4Pv1Bv>
.
|
elicwhite
reviewed
Oct 9, 2017
| @@ -19,14 +19,14 @@ module.exports = function unlinkAssetsIOS(files, projectConfig) { | |||
| if (!plist) { | |||
| return log.error( | |||
| 'ERRPLIST', | |||
| `Could not locate Info.plist file. Check if your project has 'INFOPLIST_FILE' set properly` | |||
| 'Could not locate Info.plist file. Check if your project has \'INFOPLIST_FILE\' set properly' | |||
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Oct 9, 2017
There was a problem hiding this comment.
@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This failed to import. We are working on getting the import fixed |
|
Looks like this landed. Thanks for contributing! |
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Nov 7, 2017
Summary: CI is currently failing because of a lint issue, this fixes it and a bunch of other warnings that are auto-fixable. **Test plan** Quick manual test, cosmetic changes only. Closes facebook/react-native#16229 Differential Revision: D6009748 Pulled By: TheSavior fbshipit-source-id: cabd44fed99dd90bd0b35626492719c139c89f34
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: CI is currently failing because of a lint issue, this fixes it and a bunch of other warnings that are auto-fixable. **Test plan** Quick manual test, cosmetic changes only. Closes facebook/react-native#16229 Differential Revision: D6009748 Pulled By: TheSavior fbshipit-source-id: cabd44fed99dd90bd0b35626492719c139c89f34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is currently failing because of a lint issue, this fixes it and a bunch of other warnings that are auto-fixable.
Test plan
Quick manual test, cosmetic changes only.