Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Master Task] Get Circle CI back to a good state #15726

Closed
3 of 4 tasks
hramos opened this issue Aug 31, 2017 · 0 comments
Closed
3 of 4 tasks

[Master Task] Get Circle CI back to a good state #15726

hramos opened this issue Aug 31, 2017 · 0 comments
Labels
Resolution: Locked This issue was locked by the bot. Type: Discussion Long running discussion.

Comments

@hramos
Copy link
Contributor

hramos commented Aug 31, 2017

Circle CI has been red for a while now. I've identified several different causes, each of which we'll need to address before Circle CI can get back to green.

Every day Circle remains red, we risk adding more breakages that don't get caught -- we usually get into this state when people start ignoring Circle failures due to it already failing on master prior to a diff getting landed.

Issues that need to be addressed

  • Flow errors, fixed.
  • Buck errors (see details below). Task has been opened internally for followup.
  • local-cli test fails due to use of trailing commas in function argument list in metro-bundler. Potential fix: update Circle, Travis to Node 8.2.0, OR remove use of trailing commas in metro-bundler.
  • Flow errors, again - requiring a similar fix as above.

Buck errors

One of the buck install steps started failing on Circle CI in open source after D5651764 landed. Travis CI was already failing for unrelated issues, so this particular failure wasn't noticed back then.

Circle CI job:
Every job running on master since D5651764 landed, starting with https://circleci.com/gh/facebook/react-native/20393

Command:

buck install ReactAndroid/src/androidTest/buck-runner:instrumentation-tests --config build.threads=1

Errors:

buck-out/gen/ReactAndroid/src/main/res/shell#resources-symlink-tree/res/values/styles.xml:3: error: Error retrieving parent for item: No resource found that matches the given name '@style/Theme.AppCompat.Light.NoActionBar'.
stderr: buck-out/gen/ReactAndroid/src/main/res/shell#resources-symlink-tree/res/values/styles.xml:3: error: Error retrieving parent for item: No resource found that matches the given name '@style/Theme.AppCompat.Light.NoActionBar'.
@hramos hramos added the Type: Discussion Long running discussion. label Aug 31, 2017
hramos added a commit that referenced this issue Sep 5, 2017
facebook-github-bot pushed a commit that referenced this issue Sep 5, 2017
Summary:
Workaround for #15726.
Closes #15817

Differential Revision: D5767831

Pulled By: hramos

fbshipit-source-id: f0324ed4052007648ac23f9015069a97f005d19b
ide pushed a commit that referenced this issue Sep 8, 2017
Summary:
Workaround for #15726.
Closes #15817

Differential Revision: D5767831

Pulled By: hramos

fbshipit-source-id: f0324ed4052007648ac23f9015069a97f005d19b
@hramos hramos closed this as completed Feb 28, 2018
@facebook facebook locked as resolved and limited conversation to collaborators Dec 11, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot. Type: Discussion Long running discussion.
Projects
None yet
Development

No branches or pull requests

2 participants