Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve 13608 - Expose RCTRenderingPerf output functions #13610

Conversation

beeglebug
Copy link

Motivation

You currently can not calll ReactPerf.printExclusive() when using RCTRenderingPerf because it is not exposed directly. See #13608 for full explanation and code sample.

This PR exposes all relevant print functions directly, rather than calling some of them inside stop.

Not sure if this counts a breaking change, as anyone relying on what stop does now will get no output any more.

Test Plan

To test, add the following debug code to a project:

import PerfMonitor from 'react-native/Libraries/Performance/RCTRenderingPerf'

PerfMonitor.toggle()
PerfMonitor.start()

// ...some React code

PerfMonitor.stop()
PerfMonitor.printExclusive()
PerfMonitor.printInclusive()
PerfMonitor.printWasted()

You will see the different console outputs.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. GH Review: review-needed labels Apr 21, 2017
@beeglebug
Copy link
Author

Is there something I need to do to this PR to get it moving?

@beeglebug
Copy link
Author

This has been open for 2 months now with no input from maintainers, I am happy to make any changes required to get the branch merged, but am unclear on what is required of me.

Should I pull all the recent changes on to this branch to resolve the conflicts and get it passing tests?

@beeglebug
Copy link
Author

Looking at the conflict, it seems like this change is now completely redundant, the perf stuff has changed completely since I did this, so i'll close the PR

@beeglebug beeglebug closed this Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants