Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCTRenderingPerf does not expose ReactPerf.printExclusive() #13608

Closed
beeglebug opened this issue Apr 21, 2017 · 1 comment
Closed

RCTRenderingPerf does not expose ReactPerf.printExclusive() #13608

beeglebug opened this issue Apr 21, 2017 · 1 comment
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@beeglebug
Copy link

beeglebug commented Apr 21, 2017

Description

When calling RCTRenderingPerf.stop, we automatically get the output from ReactPerf.printInclusive() and ReactPerf.printWasted(), but have no way of getting ReactPerf.printExclusive(), as it is not exposed by the module.

Reproduction Steps and Sample Code

The following code will trigger the output from printInclusive and printWasted:

import PerfMonitor from 'react-native/Libraries/Performance/RCTRenderingPerf'

PerfMonitor.toggle()
PerfMonitor.start()
setTimeout(() => {
    PerfMonitor.stop()
}, 1000)

Solution

Expose the output functions to be called directly instead of automatically calling some inside stop.

import PerfMonitor from 'react-native/Libraries/Performance/RCTRenderingPerf'

PerfMonitor.toggle()
PerfMonitor.start()
setTimeout(() => {
    PerfMonitor.stop()
    PerfMonitor.printExclusive()
    PerfMonitor.printInclusive()
    PerfMonitor.printWasted()
}, 1000)

I am happy to do a merge request for this.

Additional Information

  • React Native version: 0.43.3
@hramos
Copy link
Contributor

hramos commented Jul 20, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos added the Icebox label Jul 20, 2017
@hramos hramos closed this as completed Jul 20, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Jul 20, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants