Remove usages of RecyclerViewBackedScrollView in UIExplorer and NetworkOverlay #11999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
facebook-github-bot
added
Import Failed
and removed
Import Started
|
Let's try it again @facebook-github-bot shipit-ninja |
|
@hramos Could you try shipping again? |
|
@facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
|
@mkonicek has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Yay landed! |
edmofro
pushed a commit
to edmofro/react-native
that referenced
this pull request
Feb 6, 2017
…rkOverlay Summary: RecyclerViewBackedScrollView was deprecated, this removes usages in Examples as well as in NetworkOverlay. **Test plan** Tested that RecyclerViewBackedScrollView deprecation warning doesn't show up anymore. Closes facebook#11999 Differential Revision: D4443707 Pulled By: hramos fbshipit-source-id: 087afc9f183b3f2087965a2fe84301f422e48e9c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 7, 2017
…rkOverlay Summary: RecyclerViewBackedScrollView was deprecated, this removes usages in Examples as well as in NetworkOverlay. **Test plan** Tested that RecyclerViewBackedScrollView deprecation warning doesn't show up anymore. Closes facebook#11999 Differential Revision: D4443707 Pulled By: hramos fbshipit-source-id: 087afc9f183b3f2087965a2fe84301f422e48e9c
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Feb 8, 2017
…rkOverlay Summary: RecyclerViewBackedScrollView was deprecated, this removes usages in Examples as well as in NetworkOverlay. **Test plan** Tested that RecyclerViewBackedScrollView deprecation warning doesn't show up anymore. Closes facebook/react-native#11999 Differential Revision: D4443707 Pulled By: hramos fbshipit-source-id: 087afc9f183b3f2087965a2fe84301f422e48e9c
normanjoyner
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
…rkOverlay Summary: RecyclerViewBackedScrollView was deprecated, this removes usages in Examples as well as in NetworkOverlay. **Test plan** Tested that RecyclerViewBackedScrollView deprecation warning doesn't show up anymore. Closes facebook#11999 Differential Revision: D4443707 Pulled By: hramos fbshipit-source-id: 087afc9f183b3f2087965a2fe84301f422e48e9c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
…rkOverlay Summary: RecyclerViewBackedScrollView was deprecated, this removes usages in Examples as well as in NetworkOverlay. **Test plan** Tested that RecyclerViewBackedScrollView deprecation warning doesn't show up anymore. Closes facebook#11999 Differential Revision: D4443707 Pulled By: hramos fbshipit-source-id: 087afc9f183b3f2087965a2fe84301f422e48e9c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
…rkOverlay Summary: RecyclerViewBackedScrollView was deprecated, this removes usages in Examples as well as in NetworkOverlay. **Test plan** Tested that RecyclerViewBackedScrollView deprecation warning doesn't show up anymore. Closes facebook#11999 Differential Revision: D4443707 Pulled By: hramos fbshipit-source-id: 087afc9f183b3f2087965a2fe84301f422e48e9c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
…rkOverlay Summary: RecyclerViewBackedScrollView was deprecated, this removes usages in Examples as well as in NetworkOverlay. **Test plan** Tested that RecyclerViewBackedScrollView deprecation warning doesn't show up anymore. Closes facebook#11999 Differential Revision: D4443707 Pulled By: hramos fbshipit-source-id: 087afc9f183b3f2087965a2fe84301f422e48e9c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
…rkOverlay Summary: RecyclerViewBackedScrollView was deprecated, this removes usages in Examples as well as in NetworkOverlay. **Test plan** Tested that RecyclerViewBackedScrollView deprecation warning doesn't show up anymore. Closes facebook#11999 Differential Revision: D4443707 Pulled By: hramos fbshipit-source-id: 087afc9f183b3f2087965a2fe84301f422e48e9c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
…rkOverlay Summary: RecyclerViewBackedScrollView was deprecated, this removes usages in Examples as well as in NetworkOverlay. **Test plan** Tested that RecyclerViewBackedScrollView deprecation warning doesn't show up anymore. Closes facebook#11999 Differential Revision: D4443707 Pulled By: hramos fbshipit-source-id: 087afc9f183b3f2087965a2fe84301f422e48e9c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
…rkOverlay Summary: RecyclerViewBackedScrollView was deprecated, this removes usages in Examples as well as in NetworkOverlay. **Test plan** Tested that RecyclerViewBackedScrollView deprecation warning doesn't show up anymore. Closes facebook#11999 Differential Revision: D4443707 Pulled By: hramos fbshipit-source-id: 087afc9f183b3f2087965a2fe84301f422e48e9c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
…rkOverlay Summary: RecyclerViewBackedScrollView was deprecated, this removes usages in Examples as well as in NetworkOverlay. **Test plan** Tested that RecyclerViewBackedScrollView deprecation warning doesn't show up anymore. Closes facebook#11999 Differential Revision: D4443707 Pulled By: hramos fbshipit-source-id: 087afc9f183b3f2087965a2fe84301f422e48e9c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
…rkOverlay Summary: RecyclerViewBackedScrollView was deprecated, this removes usages in Examples as well as in NetworkOverlay. **Test plan** Tested that RecyclerViewBackedScrollView deprecation warning doesn't show up anymore. Closes facebook#11999 Differential Revision: D4443707 Pulled By: hramos fbshipit-source-id: 087afc9f183b3f2087965a2fe84301f422e48e9c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
…rkOverlay Summary: RecyclerViewBackedScrollView was deprecated, this removes usages in Examples as well as in NetworkOverlay. **Test plan** Tested that RecyclerViewBackedScrollView deprecation warning doesn't show up anymore. Closes facebook#11999 Differential Revision: D4443707 Pulled By: hramos fbshipit-source-id: 087afc9f183b3f2087965a2fe84301f422e48e9c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
…rkOverlay Summary: RecyclerViewBackedScrollView was deprecated, this removes usages in Examples as well as in NetworkOverlay. **Test plan** Tested that RecyclerViewBackedScrollView deprecation warning doesn't show up anymore. Closes facebook#11999 Differential Revision: D4443707 Pulled By: hramos fbshipit-source-id: 087afc9f183b3f2087965a2fe84301f422e48e9c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
…rkOverlay Summary: RecyclerViewBackedScrollView was deprecated, this removes usages in Examples as well as in NetworkOverlay. **Test plan** Tested that RecyclerViewBackedScrollView deprecation warning doesn't show up anymore. Closes facebook#11999 Differential Revision: D4443707 Pulled By: hramos fbshipit-source-id: 087afc9f183b3f2087965a2fe84301f422e48e9c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
…rkOverlay Summary: RecyclerViewBackedScrollView was deprecated, this removes usages in Examples as well as in NetworkOverlay. **Test plan** Tested that RecyclerViewBackedScrollView deprecation warning doesn't show up anymore. Closes facebook#11999 Differential Revision: D4443707 Pulled By: hramos fbshipit-source-id: 087afc9f183b3f2087965a2fe84301f422e48e9c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
…rkOverlay Summary: RecyclerViewBackedScrollView was deprecated, this removes usages in Examples as well as in NetworkOverlay. **Test plan** Tested that RecyclerViewBackedScrollView deprecation warning doesn't show up anymore. Closes facebook#11999 Differential Revision: D4443707 Pulled By: hramos fbshipit-source-id: 087afc9f183b3f2087965a2fe84301f422e48e9c
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
…rkOverlay Summary: RecyclerViewBackedScrollView was deprecated, this removes usages in Examples as well as in NetworkOverlay. **Test plan** Tested that RecyclerViewBackedScrollView deprecation warning doesn't show up anymore. Closes facebook#11999 Differential Revision: D4443707 Pulled By: hramos fbshipit-source-id: 087afc9f183b3f2087965a2fe84301f422e48e9c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RecyclerViewBackedScrollView was deprecated, this removes usages in Examples as well as in NetworkOverlay.
Test plan
Tested that RecyclerViewBackedScrollView deprecation warning doesn't show up anymore.