Skip to content

Commit

Permalink
Remove usages of RecyclerViewBackedScrollView in UIExplorer and Netwo…
Browse files Browse the repository at this point in the history
…rkOverlay

Summary:
RecyclerViewBackedScrollView was deprecated, this removes usages in Examples as well as in NetworkOverlay.

**Test plan**
Tested that RecyclerViewBackedScrollView deprecation warning doesn't show up anymore.
Closes facebook#11999

Differential Revision: D4443707

Pulled By: hramos

fbshipit-source-id: 087afc9f183b3f2087965a2fe84301f422e48e9c
  • Loading branch information
janicduplessis authored and nicktate committed Feb 9, 2017
1 parent 1d77708 commit b7823d0
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 12 deletions.
2 changes: 0 additions & 2 deletions Examples/UIExplorer/js/ListViewExample.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ var {
ListView,
TouchableHighlight,
StyleSheet,
RecyclerViewBackedScrollView,
Text,
View,
} = ReactNative;
Expand Down Expand Up @@ -64,7 +63,6 @@ var ListViewSimpleExample = React.createClass({
<ListView
dataSource={this.state.dataSource}
renderRow={this._renderRow}
renderScrollComponent={props => <RecyclerViewBackedScrollView {...props} />}
renderSeparator={this._renderSeparator}
/>
</UIExplorerPage>
Expand Down
2 changes: 0 additions & 2 deletions Examples/UIExplorer/js/SwipeableListViewExample.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ var {
SwipeableListView,
TouchableHighlight,
StyleSheet,
RecyclerViewBackedScrollView,
Text,
View,
Alert,
Expand Down Expand Up @@ -76,7 +75,6 @@ var SwipeableListViewSimpleExample = React.createClass({
</View>);
}}
renderRow={this._renderRow}
renderScrollComponent={props => <RecyclerViewBackedScrollView {...props} />}
renderSeparator={this._renderSeperator}
/>
</UIExplorerPage>
Expand Down
8 changes: 0 additions & 8 deletions Libraries/Inspector/NetworkOverlay.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@

const ListView = require('ListView');
const React = require('React');
const RecyclerViewBackedScrollView = require('RecyclerViewBackedScrollView');
const ScrollView = require('ScrollView');
const StyleSheet = require('StyleSheet');
const Text = require('Text');
Expand Down Expand Up @@ -367,12 +366,6 @@ class NetworkOverlay extends React.Component {
this._listViewHeight = height;
}

_renderScrollComponent(props: Object): React.Element<any> {
return (
<RecyclerViewBackedScrollView {...props} />
);
}

/**
* Popup a scrollView to dynamically show detailed information of
* the request, when pressing a row in the network flow listView.
Expand Down Expand Up @@ -500,7 +493,6 @@ class NetworkOverlay extends React.Component {
ref={this._captureRequestListView}
dataSource={this.state.dataSource}
renderRow={this._renderRow}
renderScrollComponent={this._renderScrollComponent}
enableEmptySections={true}
renderSeparator={this._renderSeperator}
onLayout={this._listViewOnLayout}
Expand Down

0 comments on commit b7823d0

Please sign in to comment.