Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selected State does not annonce when Slider Component selected #30956

Closed
amarlette opened this issue Feb 10, 2021 · 7 comments
Closed

Selected State does not annonce when Slider Component selected #30956

amarlette opened this issue Feb 10, 2021 · 7 comments
Labels
Accessibility Component: Slider Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Platform: Android Android applications. Resolution: Locked This issue was locked by the bot.

Comments

@amarlette
Copy link

amarlette commented Feb 10, 2021 •
edited
Loading

Description

Does not announce "selected" on the focus of Slider Component.

This issue is covered in-depth by parent issue #30842, please check there for more details.

React Native version:

0.63
@amarlette amarlette mentioned this issue Feb 10, 2021
Closed
5 tasks
@amarlette amarlette added Good first issue Interested in collaborating? Take a stab at fixing one of these issues. and removed Needs: Triage 🔍 labels Mar 5, 2021
@sladyn98 sladyn98 mentioned this issue Mar 12, 2021
Closed
@amarlette amarlette linked a pull request Mar 15, 2021 that will close this issue
Fix/30842 - Add accessibilityState prop in slider #31145
Closed
@satya-nutella
Copy link

satya-nutella commented Mar 20, 2021 •
edited
Loading

@amarlette Just curious if this is still relevant since the Slider component seems to have been deprecated as per #30945

@amarlette
Copy link
Author

@meehawk Thank you for tagging me on this issue, I'll see if this is still relevant.

@kacieb or @lunaleaps since this is a deprecated component per https://reactnative.dev/docs/slider can we close #30956 and #30945?

@lunaleaps
Copy link
Contributor

lunaleaps commented Mar 31, 2021 •
edited
Loading

@amarlette Since we have PR #31145 for this issue, let's keep this open for that but we can close #30945 since it's not relevant to the community

facebook-github-bot pushed a commit that referenced this issue May 21, 2021
@facebook-github-bot
Fix/30842 - Add accessibilityState prop in slider (#31145)
35dd861 
Summary:
Accessibility service does not announce "selected" on accessibilityState = {selected: true} of the Button Component.
Issue link - #30956

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->

[General] [Added] - Add accessibilityState prop to Slider component

Pull Request resolved: #31145

Test Plan:
Verified accessibility states are read by voiceover and talkback. Some state values aren't handled by iOS and have been identified.

Added snapshot tests to test accessibilityState.disabled = disabled values

`js1 test Slider-test`

Reviewed By: yungsters

Differential Revision: D28337723

Pulled By: lunaleaps

fbshipit-source-id: 72a54d8d9dcf1fafb9785c81da99f32a21f3df00
@amarlette
Copy link
Author

Thank you @sladyn98 for your contribution to a more accessible React Native! Can you comment your Twitter handle if you have one so that I can give you a shout-out?

@sladyn98
Copy link
Contributor

@amarlette my twitter handle is @SladynN .Thanks for the shoutout

@gabrieldonadel
Copy link
Collaborator

Quick question @amarlette and @lunaleaps, is there something else to be done here or can we close this issue?

@lunaleaps
Copy link
Contributor

I think we can close this issue, thanks for the notice!

@facebook facebook locked as resolved and limited conversation to collaborators Jan 20, 2023
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Accessibility Component: Slider Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Platform: Android Android applications. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/30842 - Add accessibilityState prop in slider sladyn98/react-native
6 participants
@lunaleaps @amarlette @gabrieldonadel @sladyn98 @react-native-bot @satya-nutella