Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Selected State does not annonce when selected #30842

Closed
3 of 5 tasks
amarlette opened this issue Feb 3, 2021 · 6 comments
Closed
3 of 5 tasks

Android: Selected State does not annonce when selected #30842

amarlette opened this issue Feb 3, 2021 · 6 comments
Labels
Accessibility Team - Evaluated Accessibility Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Platform: Android Android applications. React Native Engineering - Evaluated

Comments

@amarlette
Copy link

amarlette commented Feb 3, 2021

Description

Does not announce "selected" on focus of:

React Native version:

v0.63

Expected Behavior

Upon focus of an element with the "selected" accessibilityState set to true, the focus announcement should say "selected". Upon change from selected to not selected, no additional announcement should be made, however on state change from unselected to selected, an announcement of "selected" should be made. This works properly on some element, such as <Text>, and not on others, such as <Button>.

Snack

https://snack.expo.io/NCALByZTa

Android Details

The "selected" accessibilityState should correlate with Android's View's "selected" property, which seems to be properly working in most instances. It is likely the components where this doesn't work have problems on the Javascript side, and not the Android side.

@sladyn98
Copy link
Contributor

sladyn98 commented Mar 9, 2021

Looks like a good first issue. Any tips on how to get started with this like the files I should be looking at . Thanks

@amarlette
Copy link
Author

amarlette commented Mar 11, 2021

@sladyn98 I would recommend first looking at https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md if you haven't contributed to RN before. When it comes to where to start it looks like @intergalacticspacehighway has submitted a pull request for #30954 (pull request is #31116) so their fixes for Button would be a good place to start since the other components have similar issues.

@huzaifaaak
Copy link

This works properly on some element, such as , and not on others, such as .
@blavalla can you please update the components here ?

@blavalla
Copy link
Contributor

This works properly on some element, such as , and not on others, such as .
@blavalla can you please update the components here ?

Sorry for the bad markdown! It was trying to interpret the React component names as HTML and just seemed to give up :)

I updated the description to clarify.

@ishqelliot
Copy link

@amarlette all the listed issues are closed, is there anything remaining in this issue that needs to be picked?

@davwheat
Copy link

Bump - looks like all tasks are completed @amarlette

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Team - Evaluated Accessibility Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Platform: Android Android applications. React Native Engineering - Evaluated
Projects
None yet
Development

No branches or pull requests

7 participants