-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Re-enabled disabled tests ReactPropForShadowNodeSpecTest and ReactPro…
…pForShadowNodeSetterTest (#41788) Summary: X-link: facebook/yoga#1494 Pull Request resolved: #41788 Those tests are currently disabled due to Yoga attempting to do JNI calls. I've added infra to bypass .so loading during tests, and we should be good to re-enable those tests by now. Changelog: [Internal] [Changed] - Re-enabled disabled tests ReactPropForShadowNodeSpecTest and ReactPropForShadowNodeSetterTest Reviewed By: NickGerleman Differential Revision: D51814491 fbshipit-source-id: adbbace19c94a0c6d8947f61221fafafd7797ac8
- Loading branch information
Showing
8 changed files
with
377 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 57 additions & 0 deletions
57
...es/react-native/ReactAndroid/src/test/java/com/facebook/testutils/fakes/FakeYogaConfig.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| /* | ||
| * Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| package com.facebook.testutils.fakes | ||
|
|
||
| import com.facebook.yoga.YogaConfig | ||
| import com.facebook.yoga.YogaErrata | ||
| import com.facebook.yoga.YogaExperimentalFeature | ||
| import com.facebook.yoga.YogaLogger | ||
|
|
||
| /** A fake [YogaConfig] that allows us to test Yoga without using the real JNI. */ | ||
| class FakeYogaConfig : YogaConfig() { | ||
| var fakeErrata: YogaErrata? = YogaErrata.NONE | ||
| var fakeLogger: YogaLogger? = YogaLogger { _, _ -> | ||
| // no-op | ||
| } | ||
|
|
||
| override fun setExperimentalFeatureEnabled(feature: YogaExperimentalFeature?, enabled: Boolean) { | ||
| // no-op | ||
| } | ||
|
|
||
| override fun setUseWebDefaults(useWebDefaults: Boolean) { | ||
| // no-op | ||
| } | ||
|
|
||
| override fun setPrintTreeFlag(enable: Boolean) { | ||
| // no-op | ||
| } | ||
|
|
||
| override fun setPointScaleFactor(pixelsInPoint: Float) { | ||
| // no-op | ||
| } | ||
|
|
||
| override fun setErrata(errata: YogaErrata?) { | ||
| fakeErrata = errata | ||
| } | ||
|
|
||
| override fun getErrata(): YogaErrata? { | ||
| return fakeErrata | ||
| } | ||
|
|
||
| override fun setLogger(logger: YogaLogger?) { | ||
| fakeLogger = logger | ||
| } | ||
|
|
||
| override fun getLogger(): YogaLogger? { | ||
| return fakeLogger | ||
| } | ||
|
|
||
| override fun getNativePointer(): Long { | ||
| return 0L | ||
| } | ||
| } |
251 changes: 251 additions & 0 deletions
251
...ages/react-native/ReactAndroid/src/test/java/com/facebook/testutils/fakes/FakeYogaNode.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,251 @@ | ||
| /* | ||
| * Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| package com.facebook.testutils.fakes | ||
|
|
||
| import com.facebook.yoga.YogaAlign | ||
| import com.facebook.yoga.YogaBaselineFunction | ||
| import com.facebook.yoga.YogaConstants | ||
| import com.facebook.yoga.YogaDirection | ||
| import com.facebook.yoga.YogaDisplay | ||
| import com.facebook.yoga.YogaEdge | ||
| import com.facebook.yoga.YogaFlexDirection | ||
| import com.facebook.yoga.YogaGutter | ||
| import com.facebook.yoga.YogaJustify | ||
| import com.facebook.yoga.YogaMeasureFunction | ||
| import com.facebook.yoga.YogaNode | ||
| import com.facebook.yoga.YogaOverflow | ||
| import com.facebook.yoga.YogaPositionType | ||
| import com.facebook.yoga.YogaUnit | ||
| import com.facebook.yoga.YogaValue | ||
| import com.facebook.yoga.YogaWrap | ||
|
|
||
| /** A fake [YogaNode] that allows us to test Yoga without using the real JNI. */ | ||
| class FakeYogaNode : YogaNode() { | ||
| override fun setWidth(width: Float) {} | ||
|
|
||
| override fun setWidthPercent(percent: Float) {} | ||
|
|
||
| override fun setMinWidth(minWidth: Float) {} | ||
|
|
||
| override fun setMinWidthPercent(percent: Float) {} | ||
|
|
||
| override fun setMaxWidth(maxWidth: Float) {} | ||
|
|
||
| override fun setMaxWidthPercent(percent: Float) {} | ||
|
|
||
| override fun setWidthAuto() {} | ||
|
|
||
| override fun setHeight(height: Float) {} | ||
|
|
||
| override fun setHeightPercent(percent: Float) {} | ||
|
|
||
| override fun setMinHeight(minHeight: Float) {} | ||
|
|
||
| override fun setMinHeightPercent(percent: Float) {} | ||
|
|
||
| override fun setMaxHeight(maxheight: Float) {} | ||
|
|
||
| override fun setMaxHeightPercent(percent: Float) {} | ||
|
|
||
| override fun setHeightAuto() {} | ||
|
|
||
| override fun setMargin(edge: YogaEdge?, margin: Float) {} | ||
|
|
||
| override fun setMarginPercent(edge: YogaEdge?, percent: Float) {} | ||
|
|
||
| override fun setMarginAuto(edge: YogaEdge?) {} | ||
|
|
||
| override fun setPadding(edge: YogaEdge?, padding: Float) {} | ||
|
|
||
| override fun setPaddingPercent(edge: YogaEdge?, percent: Float) {} | ||
|
|
||
| override fun setPositionType(positionType: YogaPositionType?) {} | ||
|
|
||
| override fun setPosition(edge: YogaEdge?, position: Float) {} | ||
|
|
||
| override fun setPositionPercent(edge: YogaEdge?, percent: Float) {} | ||
|
|
||
| override fun setAlignContent(alignContent: YogaAlign?) {} | ||
|
|
||
| override fun setAlignItems(alignItems: YogaAlign?) {} | ||
|
|
||
| override fun setAlignSelf(alignSelf: YogaAlign?) {} | ||
|
|
||
| override fun setFlex(flex: Float) {} | ||
|
|
||
| override fun setFlexBasisAuto() {} | ||
|
|
||
| override fun setFlexBasisPercent(percent: Float) {} | ||
|
|
||
| override fun setFlexBasis(flexBasis: Float) {} | ||
|
|
||
| override fun setFlexDirection(flexDirection: YogaFlexDirection?) {} | ||
|
|
||
| override fun setFlexGrow(flexGrow: Float) {} | ||
|
|
||
| override fun setFlexShrink(flexShrink: Float) {} | ||
|
|
||
| override fun setJustifyContent(justifyContent: YogaJustify?) {} | ||
|
|
||
| override fun setDirection(direction: YogaDirection?) {} | ||
|
|
||
| override fun setBorder(edge: YogaEdge?, border: Float) {} | ||
|
|
||
| override fun setWrap(flexWrap: YogaWrap?) {} | ||
|
|
||
| override fun setAspectRatio(aspectRatio: Float) {} | ||
|
|
||
| override fun setIsReferenceBaseline(isReferenceBaseline: Boolean) {} | ||
|
|
||
| override fun setMeasureFunction(measureFunction: YogaMeasureFunction?) {} | ||
|
|
||
| override fun setBaselineFunction(baselineFunction: YogaBaselineFunction?) {} | ||
|
|
||
| override fun getWidth(): YogaValue = YogaValue(YogaConstants.UNDEFINED, YogaUnit.UNDEFINED) | ||
|
|
||
| override fun getMinWidth(): YogaValue = YogaValue(YogaConstants.UNDEFINED, YogaUnit.UNDEFINED) | ||
|
|
||
| override fun getMaxWidth(): YogaValue = YogaValue(YogaConstants.UNDEFINED, YogaUnit.UNDEFINED) | ||
|
|
||
| override fun getHeight(): YogaValue = YogaValue(YogaConstants.UNDEFINED, YogaUnit.UNDEFINED) | ||
|
|
||
| override fun getMinHeight(): YogaValue = YogaValue(YogaConstants.UNDEFINED, YogaUnit.UNDEFINED) | ||
|
|
||
| override fun getMaxHeight(): YogaValue = YogaValue(YogaConstants.UNDEFINED, YogaUnit.UNDEFINED) | ||
|
|
||
| override fun getStyleDirection(): YogaDirection = YogaDirection.INHERIT | ||
|
|
||
| override fun getFlexDirection(): YogaFlexDirection = YogaFlexDirection.COLUMN | ||
|
|
||
| override fun getJustifyContent(): YogaJustify = YogaJustify.FLEX_START | ||
|
|
||
| override fun getAlignItems(): YogaAlign = YogaAlign.FLEX_START | ||
|
|
||
| override fun getAlignSelf(): YogaAlign = YogaAlign.FLEX_START | ||
|
|
||
| override fun getAlignContent(): YogaAlign = YogaAlign.FLEX_START | ||
|
|
||
| override fun getPositionType(): YogaPositionType = YogaPositionType.RELATIVE | ||
|
|
||
| override fun getFlexGrow(): Float = 0f | ||
|
|
||
| override fun getFlexShrink(): Float = 0f | ||
|
|
||
| override fun getFlexBasis(): YogaValue = YogaValue(YogaConstants.UNDEFINED, YogaUnit.UNDEFINED) | ||
|
|
||
| override fun getAspectRatio(): Float = 0f | ||
|
|
||
| override fun getMargin(edge: YogaEdge?): YogaValue = | ||
| YogaValue(YogaConstants.UNDEFINED, YogaUnit.UNDEFINED) | ||
|
|
||
| override fun getPadding(edge: YogaEdge?): YogaValue = | ||
| YogaValue(YogaConstants.UNDEFINED, YogaUnit.UNDEFINED) | ||
|
|
||
| override fun getPosition(edge: YogaEdge?): YogaValue = | ||
| YogaValue(YogaConstants.UNDEFINED, YogaUnit.UNDEFINED) | ||
|
|
||
| override fun getBorder(edge: YogaEdge?): Float = 0f | ||
|
|
||
| override fun reset() { | ||
| // no-op | ||
| } | ||
|
|
||
| override fun getChildCount(): Int = 0 | ||
|
|
||
| override fun getChildAt(i: Int): YogaNode = FakeYogaNode() | ||
|
|
||
| override fun addChildAt(child: YogaNode?, i: Int) { | ||
| // no-op | ||
| } | ||
|
|
||
| override fun isReferenceBaseline(): Boolean = false | ||
|
|
||
| override fun removeChildAt(i: Int): YogaNode = FakeYogaNode() | ||
|
|
||
| override fun getOwner(): YogaNode? = null | ||
|
|
||
| @Deprecated("Deprecated in Java") override fun getParent(): YogaNode? = null | ||
|
|
||
| override fun indexOf(child: YogaNode?): Int = 0 | ||
|
|
||
| override fun calculateLayout(width: Float, height: Float) { | ||
| // no-op | ||
| } | ||
|
|
||
| override fun hasNewLayout(): Boolean = false | ||
|
|
||
| override fun dirty() { | ||
| // no-op | ||
| } | ||
|
|
||
| override fun isDirty(): Boolean = false | ||
|
|
||
| override fun copyStyle(srcNode: YogaNode?) { | ||
| // no-op | ||
| } | ||
|
|
||
| override fun markLayoutSeen() { | ||
| // no-op | ||
| } | ||
|
|
||
| override fun getWrap(): YogaWrap = YogaWrap.WRAP | ||
|
|
||
| override fun getOverflow(): YogaOverflow = YogaOverflow.HIDDEN | ||
|
|
||
| override fun setOverflow(overflow: YogaOverflow?) { | ||
| // no-op | ||
| } | ||
|
|
||
| override fun getDisplay(): YogaDisplay = YogaDisplay.NONE | ||
|
|
||
| override fun setDisplay(display: YogaDisplay?) { | ||
| // no-op | ||
| } | ||
|
|
||
| override fun getFlex(): Float = 0f | ||
|
|
||
| override fun getGap(gutter: YogaGutter?): Float = 0f | ||
|
|
||
| override fun setGap(gutter: YogaGutter?, gapLength: Float) { | ||
| // no-op | ||
| } | ||
|
|
||
| override fun getLayoutX(): Float = 0f | ||
|
|
||
| override fun getLayoutY(): Float = 0f | ||
|
|
||
| override fun getLayoutWidth(): Float = 0f | ||
|
|
||
| override fun getLayoutHeight(): Float = 0f | ||
|
|
||
| override fun getLayoutMargin(edge: YogaEdge?): Float = 0f | ||
|
|
||
| override fun getLayoutPadding(edge: YogaEdge?): Float = 0f | ||
|
|
||
| override fun getLayoutBorder(edge: YogaEdge?): Float = 0f | ||
|
|
||
| override fun getLayoutDirection(): YogaDirection = YogaDirection.INHERIT | ||
|
|
||
| override fun isMeasureDefined(): Boolean = true | ||
|
|
||
| override fun isBaselineDefined(): Boolean = true | ||
|
|
||
| override fun setData(data: Any?) { | ||
| // no-op | ||
| } | ||
|
|
||
| override fun getData(): Any? = null | ||
|
|
||
| override fun print() { | ||
| // no-op | ||
| } | ||
|
|
||
| override fun cloneWithoutChildren(): YogaNode = FakeYogaNode() | ||
|
|
||
| override fun cloneWithChildren(): YogaNode = FakeYogaNode() | ||
| } |
Oops, something went wrong.