Re-enabled disabled tests ReactPropForShadowNodeSpecTest and ReactPropForShadowNodeSetterTest #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D51814491 |
cortinico
force-pushed
the
export-D51814491
branch
from
3092b62
to
702b037
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51814491 |
…pForShadowNodeSetterTest (facebook#1494) Summary: X-link: facebook/react-native#41788 Those tests are currently disabled due to Yoga attempting to do JNI calls. I've added infra to bypass .so loading during tests, and we should be good to re-enable those tests by now. Changelog: [Internal] [Changed] - Re-enabled disabled tests ReactPropForShadowNodeSpecTest and ReactPropForShadowNodeSetterTest Reviewed By: NickGerleman Differential Revision: D51814491
cortinico
force-pushed
the
export-D51814491
branch
from
702b037
to
8644f14
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Dec 5, 2023
…pForShadowNodeSetterTest (facebook#41788) Summary: X-link: facebook/yoga#1494 Those tests are currently disabled due to Yoga attempting to do JNI calls. I've added infra to bypass .so loading during tests, and we should be good to re-enable those tests by now. Changelog: [Internal] [Changed] - Re-enabled disabled tests ReactPropForShadowNodeSpecTest and ReactPropForShadowNodeSetterTest Reviewed By: NickGerleman Differential Revision: D51814491
|
This pull request was exported from Phabricator. Differential Revision: D51814491 |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Dec 5, 2023
…pForShadowNodeSetterTest Summary: X-link: facebook/yoga#1494 X-link: facebook/react-native#41788 Those tests are currently disabled due to Yoga attempting to do JNI calls. I've added infra to bypass .so loading during tests, and we should be good to re-enable those tests by now. Changelog: [Internal] [Changed] - Re-enabled disabled tests ReactPropForShadowNodeSpecTest and ReactPropForShadowNodeSetterTest Reviewed By: NickGerleman Differential Revision: D51814491 fbshipit-source-id: adbbace19c94a0c6d8947f61221fafafd7797ac8
|
This pull request has been merged in 7b3b66d. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Dec 5, 2023
…pForShadowNodeSetterTest (#41788) Summary: X-link: facebook/yoga#1494 Pull Request resolved: #41788 Those tests are currently disabled due to Yoga attempting to do JNI calls. I've added infra to bypass .so loading during tests, and we should be good to re-enable those tests by now. Changelog: [Internal] [Changed] - Re-enabled disabled tests ReactPropForShadowNodeSpecTest and ReactPropForShadowNodeSetterTest Reviewed By: NickGerleman Differential Revision: D51814491 fbshipit-source-id: adbbace19c94a0c6d8947f61221fafafd7797ac8
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…pForShadowNodeSetterTest (facebook#41788) Summary: X-link: facebook/yoga#1494 Pull Request resolved: facebook#41788 Those tests are currently disabled due to Yoga attempting to do JNI calls. I've added infra to bypass .so loading during tests, and we should be good to re-enable those tests by now. Changelog: [Internal] [Changed] - Re-enabled disabled tests ReactPropForShadowNodeSpecTest and ReactPropForShadowNodeSetterTest Reviewed By: NickGerleman Differential Revision: D51814491 fbshipit-source-id: adbbace19c94a0c6d8947f61221fafafd7797ac8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Those tests are currently disabled due to Yoga attempting to do JNI calls.
I've added infra to bypass .so loading during tests, and we should be good to re-enable those tests by now.
Changelog:
[Internal] [Changed] - Re-enabled disabled tests ReactPropForShadowNodeSpecTest and ReactPropForShadowNodeSetterTest
Differential Revision: D51814491