Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default value of textBreakStrategy prop of TextInput component #3881

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

aswin-s
Copy link
Contributor

@aswin-s aswin-s commented Oct 11, 2023

This PR updates the default value of textBreakStrategy prop of TextInput component to 'highQuality' instead of 'simple'. This has been the default behaviour for quite some time now and it is tripping off developers. More details regarding this mismatch is available at facebook/react-native#38244

@netlify
Copy link

netlify bot commented Oct 11, 2023

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 409c001
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/6526922abd435e00084b9b3f
😎 Deploy Preview https://deploy-preview-3881--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Simek Simek added 🕐 Waiting on PR These may be waiting for a PR to the facebook/react-native to be merged Wait on future Release This indicates a PR that updates the doc to match a future release. and removed 🕐 Waiting on PR These may be waiting for a PR to the facebook/react-native to be merged Wait on future Release This indicates a PR that updates the doc to match a future release. labels Oct 11, 2023
Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After digging a bit through the code it looks like highQuality has been a default value for a while. Nice catch, thank you for the updates! 👍

@Simek Simek merged commit af27da0 into facebook:main Oct 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants