[$2000] Unnecessary new lines created when user mentions a contact #21615

kavimuru · 2023-06-26T19:06:17Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Action Performed:

Open ND on Android
Open any chat and type @
Select any one contact from the list which has a long email
Observe the mentioned contact email in the composer

Expected Result:

Extra new lines should not be created since there is enough space inside the composer

Actual Result:

Extra new lines are created and app is not using the white space after the email.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.32-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.20230626.195148.New.Expensify.mp4

Screen_Recording_20230621_161514_New.Expensify.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687353655609189

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01c301c436377b47aa
Upwork Job ID: 1673794132243972096
Last Price Increase: 2023-07-19
Automatic offers:

s77rt | Reviewer | 27161424
aswin-s | Contributor | 27161425
nathan-mulugeta | Reporter | 27161427

melvin-bot · 2023-06-26T19:06:22Z

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-06-26T19:06:24Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

joekaufmanexpensify · 2023-06-26T20:35:04Z

I can reproduce this, but am not 100% convinced this is a bug. The mention does break into multiple lines with extra space. But then if you type on one of the middle lines, it fills out the extra space.

2023-06-26_16-28-45.mp4

joekaufmanexpensify · 2023-06-26T20:41:08Z

Discussing here

joekaufmanexpensify · 2023-06-27T20:43:07Z

Discussed here, and this is a bug, since it only happens with mentions.

melvin-bot · 2023-06-27T20:43:16Z

Job added to Upwork: https://www.upwork.com/jobs/~01c301c436377b47aa

melvin-bot · 2023-06-27T20:43:19Z

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-06-27T20:43:26Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

joekaufmanexpensify · 2023-06-28T19:15:27Z

Waiting for proposals

joekaufmanexpensify · 2023-06-29T18:38:35Z

Same

joekaufmanexpensify · 2023-06-30T17:38:17Z

Still waiting for proposals.

joekaufmanexpensify · 2023-07-03T13:05:38Z

Same

melvin-bot · 2023-07-04T16:00:18Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot · 2023-07-05T18:28:53Z

Upwork job price has been updated to $2000

joekaufmanexpensify · 2023-07-05T18:30:05Z

Bumped price as there have been no proposals here thus far. Also just highlighted this in Slack.

joekaufmanexpensify · 2023-07-06T17:50:49Z

Still pending proposals.

aswin-s · 2023-07-07T06:08:47Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Text in composer wraps early even when there is enough white space available towards right

What is the root cause of that problem?

Native TextInput component on Android uses 'highQuality' line break strategy. This strategy scans the entire paragraph and wraps the multi line text for better readability. That's the reason it breaks the email '[email protected]' early when it encounters a series of number after the text. This behaviour is also annoying when user tries to delete characters from the end of the long string as the text wrapping keeps on changing with each character being removed.

What changes do you think we should make in order to solve the problem?

The BaseTextInput component extends the RNTextInput which is basically a wrapper over TextInput component from ReactNative. We need to set the prop `textBreakStrategy' as 'simple' to this 'RNTextInout' component, so that all instances of TextInput used within the app will have simple break strategy. This is an Android only prop which maps to the native lineBreakStrategy prop on Android.

Make change at the below line

App/src/components/RNTextInput.js

Line 23 in e825aa7

allowFontScaling={false}

function RNTextInput(props) {
    return (
        <AnimatedTextInput
            allowFontScaling={false}
            // Add this prop 
            textBreakStrategy="simple"
            ...
/>

Before

After

What alternative solutions did you explore? (Optional)

None

s77rt · 2023-07-07T15:03:07Z

@aswin-s Thanks for the proposal. Although your RCA makes sense I'm not sure we are at the very root cause yet. textBreakStrategy default value should already be simple¹, how come it's not the case?

https://github.com/Expensify/react-native/blob/9837731f7bbf93949344c3cc74fdc304764085e4/Libraries/Components/TextInput/AndroidTextInputNativeComponent.js#L196-L199 ↩

melvin-bot · 2023-10-12T14:36:53Z

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2023-10-12T14:36:57Z

📣 @aswin-s 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

melvin-bot · 2023-10-12T14:37:02Z

📣 @Nathan-Mulugeta 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

aswin-s · 2023-10-12T16:16:32Z

Accepted the offer and raised PR.

joekaufmanexpensify · 2023-10-16T14:56:55Z

Sounds good!

aswin-s · 2023-10-18T00:41:52Z

PR is deployed to production. Melvin doesn't seem to care.

joekaufmanexpensify · 2023-10-23T14:12:24Z

Interesting. Yep, I see this one is all set. @s77rt @aswin-s is anything else needed for this one? If not, I will spin up the BZ checklist today manually so we can get that done, issue payment, and then close this out!

aswin-s · 2023-10-23T14:20:57Z

@joekaufmanexpensify All good from my side.

s77rt · 2023-10-23T20:28:09Z

The PR that introduced the bug has been identified: n/a. The bug is in RN (and its outdated documents)
The offending PR has been commented on: n/a
A discussion in #expensify-bugs has been started: Not needed for this case as we already have a lint rule to force the use of our custom TextInput (which includes the fix) instead of RN's TextInput
Determine if we should create a regression test for this bug: I don't think this is needed for the same reason above

s77rt · 2023-10-23T20:28:32Z

@joekaufmanexpensify All is good. Checklist provided above ^

aswin-s · 2023-10-23T21:32:36Z

@joekaufmanexpensify PR was merged within 3 days of assignment. Is speed bonus applicable here?

joekaufmanexpensify · 2023-10-30T21:30:08Z

Switching to this to daily so I can organize the payment next steps. I will look into the applicability of urgency bonus here as well.

joekaufmanexpensify · 2023-10-31T22:01:16Z

Discussing speed bonus.

joekaufmanexpensify · 2023-11-01T21:01:16Z

Okay, we discussed in the above thread and confirmed this is eligible for a speed bonus. So we need to make the following payments:

@aswin-s - $3000 ($2000 for bounty + $1000 speed bonus). Paid via Upwork.
@s77rt - $3000 ($2000 for C+ review + $1000 speed bonus). Paid via Upwork.
@Nathan-Mulugeta - $250 for reporting. Paid via Upwork.

joekaufmanexpensify · 2023-11-01T21:02:37Z

@aswin-s $3000 sent and contract ended!

Nathan-Mulugeta · 2023-11-01T21:03:16Z

Hey @joekaufmanexpensify The reporting bonus for this one is based on the previous bounty since this issue was opened before the adjustment

joekaufmanexpensify · 2023-11-01T21:03:35Z

@s77rt $3000 sent and contract ended!

joekaufmanexpensify · 2023-11-01T21:03:54Z

Hey @joekaufmanexpensify The reporting bonus for this one is based on the previous bounty since this issue was opened before the adjustment

Ah, good call. Let me double check the timing on that!

joekaufmanexpensify · 2023-11-01T21:06:59Z

Okay, yep. Reporting will be $250, since this was reported before August, 30th.

Nathan-Mulugeta · 2023-11-01T21:08:05Z

Great thanks

joekaufmanexpensify · 2023-11-01T21:08:43Z

@Nathan-Mulugeta $250 sent and contract ended!

joekaufmanexpensify · 2023-11-01T21:09:11Z

Bug is fixed, and all payment issued. Closing as this is all set. Thanks everyone!

kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 26, 2023

melvin-bot bot assigned joekaufmanexpensify Jun 26, 2023

joekaufmanexpensify added the External Added to denote the issue can be worked on by a contributor label Jun 27, 2023

melvin-bot bot changed the title ~~Unnecessary new lines created when user mentions a contact~~ [$1000] Unnecessary new lines created when user mentions a contact Jun 27, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 27, 2023

melvin-bot bot assigned s77rt Jun 27, 2023

melvin-bot bot added the Overdue label Jul 3, 2023

melvin-bot bot removed the Overdue label Jul 3, 2023

joekaufmanexpensify changed the title ~~[$1000] Unnecessary new lines created when user mentions a contact~~ [$2000] Unnecessary new lines created when user mentions a contact Jul 5, 2023

melvin-bot bot added the Overdue label Jul 5, 2023

melvin-bot bot removed the Overdue label Jul 5, 2023

Li357 assigned aswin-s Oct 12, 2023

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 12, 2023

aswin-s mentioned this issue Oct 12, 2023

fix: set default textBreakStrategy for TextInput as simple #29467

Merged

60 tasks

joekaufmanexpensify changed the title ~~[hold for upstream PR] [$2000] Unnecessary new lines created when user mentions a contact~~ [$2000] Unnecessary new lines created when user mentions a contact Oct 16, 2023

s77rt mentioned this issue Oct 18, 2023

[HOLD for payment 2023-10-19] Payment issue for E/App PR#29467 #29479

Closed

joekaufmanexpensify added Daily KSv2 and removed Weekly KSv2 labels Oct 30, 2023

joekaufmanexpensify closed this as completed Nov 1, 2023

[$2000] Unnecessary new lines created when user mentions a contact #21615

[$2000] Unnecessary new lines created when user mentions a contact #21615

Comments

kavimuru commented Jun 26, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Jun 26, 2023

melvin-bot bot commented Jun 26, 2023 • edited by joekaufmanexpensify Loading

Bug0 Triage Checklist (Main S/O)

joekaufmanexpensify commented Jun 26, 2023

joekaufmanexpensify commented Jun 26, 2023

joekaufmanexpensify commented Jun 27, 2023

melvin-bot bot commented Jun 27, 2023

melvin-bot bot commented Jun 27, 2023

melvin-bot bot commented Jun 27, 2023

joekaufmanexpensify commented Jun 28, 2023

joekaufmanexpensify commented Jun 29, 2023

joekaufmanexpensify commented Jun 30, 2023

joekaufmanexpensify commented Jul 3, 2023

melvin-bot bot commented Jul 4, 2023

melvin-bot bot commented Jul 5, 2023

joekaufmanexpensify commented Jul 5, 2023

joekaufmanexpensify commented Jul 6, 2023

aswin-s commented Jul 7, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

s77rt commented Jul 7, 2023

Footnotes

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

aswin-s commented Oct 12, 2023

joekaufmanexpensify commented Oct 16, 2023

aswin-s commented Oct 18, 2023

joekaufmanexpensify commented Oct 23, 2023

aswin-s commented Oct 23, 2023

s77rt commented Oct 23, 2023

s77rt commented Oct 23, 2023

aswin-s commented Oct 23, 2023

joekaufmanexpensify commented Oct 30, 2023

joekaufmanexpensify commented Oct 31, 2023

joekaufmanexpensify commented Nov 1, 2023 • edited Loading

joekaufmanexpensify commented Nov 1, 2023

Nathan-Mulugeta commented Nov 1, 2023

joekaufmanexpensify commented Nov 1, 2023

joekaufmanexpensify commented Nov 1, 2023

joekaufmanexpensify commented Nov 1, 2023 • edited Loading

Nathan-Mulugeta commented Nov 1, 2023

joekaufmanexpensify commented Nov 1, 2023

joekaufmanexpensify commented Nov 1, 2023

kavimuru commented Jun 26, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jun 26, 2023 •

edited by joekaufmanexpensify

Loading

aswin-s commented Jul 7, 2023 •

edited

Loading

joekaufmanexpensify commented Nov 1, 2023 •

edited

Loading

joekaufmanexpensify commented Nov 1, 2023 •

edited

Loading