Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-react] update flow typing for draggable block plugin #6426

Merged
merged 2 commits into from
Jul 19, 2024
Merged

[lexical-react] update flow typing for draggable block plugin #6426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
211be1b
flow
potatowagon Jul 19, 2024
660937f
fix flow error
potatowagon Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/lexical-playground/src/plugins/DraggableBlockPlugin/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ function isOnMenu(element: HTMLElement): boolean {
return !!element.closest(`.${DRAGGABLE_BLOCK_MENU_CLASSNAME}`);
}

export default function PlaygroundDraggableBlockPlugin({
export default function DraggableBlockPlugin({
Copy link
Contributor Author

@potatowagon potatowagon Jul 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to match file name, in Editor.tsx it is DraggableBlockPlugin

anchorElem = document.body,
}: {
anchorElem?: HTMLElement;
Expand Down
13 changes: 12 additions & 1 deletion packages/lexical-react/flow/LexicalDraggableBlockPlugin.js.flow
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,15 @@
* @flow strict
*/

declare export function DraggableBlockPlugin(): React$MixedElement;
import * as React from 'react';

type Props = $ReadOnly<{
anchorElem?: HTMLElement,
menuRef: React.RefObject<?HTMLElement>,
targetLineRef: React.RefObject<?HTMLElement>,
menuComponent: React.Node,
targetLineComponent: React.Node,
isOnMenu: (element: HTMLElement) => boolean,
}>;

declare export function DraggableBlockPlugin_EXPERIMENTAL(props: Props): React$MixedElement;
Loading