Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-react] update flow typing for draggable block plugin #6426

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Conversation

potatowagon
Copy link
Contributor

@potatowagon potatowagon commented Jul 19, 2024

Description

update flow typing

Test plan

works fine

Screenshot 2024-07-19 at 4 50 25 PM

Copy link

vercel bot commented Jul 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 11:26am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 11:26am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 19, 2024
@@ -16,7 +16,7 @@ function isOnMenu(element: HTMLElement): boolean {
return !!element.closest(`.${DRAGGABLE_BLOCK_MENU_CLASSNAME}`);
}

export default function PlaygroundDraggableBlockPlugin({
export default function DraggableBlockPlugin({
Copy link
Contributor Author

@potatowagon potatowagon Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to match file name, in Editor.tsx it is DraggableBlockPlugin

Copy link

github-actions bot commented Jul 19, 2024

size-limit report 📦

Path Size
lexical - cjs 28.76 KB (0%)
lexical - esm 28.61 KB (0%)
@lexical/rich-text - cjs 37.2 KB (0%)
@lexical/rich-text - esm 28.21 KB (0%)
@lexical/plain-text - cjs 35.85 KB (0%)
@lexical/plain-text - esm 25.5 KB (0%)
@lexical/react - cjs 39.12 KB (0%)
@lexical/react - esm 29.49 KB (0%)

@potatowagon potatowagon added this pull request to the merge queue Jul 19, 2024
Merged via the queue into main with commit 40f6cac Jul 19, 2024
45 checks passed
@potatowagon potatowagon deleted the flow branch July 26, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants