BigInt typechecking

newtests/bigint/test.js

@@ -201,156 +201,7 @@ export default suite(({ addFile, addFiles, addCode }) => [
       const valid_neg_small = -100n;
       type ValidSmall = 100n;
       type ValidNegSmall = -1n;
-    `).newErrors(
-        `
-          test.js:4
-            4:       type S = bigint;
-                              ^^^^^^ BigInt bigint [1] is not yet supported.
-            References:
-              4:       type S = bigint;
-                                ^^^^^^ [1]
-
-          test.js:6
-            6:       const valid_binary = 0b101011101n;
-                                          ^^^^^^^^^^^^ BigInt bigint literal \`0b101011101n\` [1] is not yet supported.
-            References:
-              6:       const valid_binary = 0b101011101n;
-                                            ^^^^^^^^^^^^ [1]
-
-          test.js:7
-            7:       const valid_neg_binary = -0b101011101n;
-                                               ^^^^^^^^^^^^ BigInt bigint literal \`0b101011101n\` [1] is not yet supported.
-            References:
-              7:       const valid_neg_binary = -0b101011101n;
-                                                 ^^^^^^^^^^^^ [1]
-
-          test.js:8
-            8:       type ValidBinary = 0b101011101n;
-                                        ^^^^^^^^^^^^ BigInt bigint literal \`0b101011101n\` [1] is not yet supported.
-            References:
-              8:       type ValidBinary = 0b101011101n;
-                                          ^^^^^^^^^^^^ [1]
-
-          test.js:9
-            9:       type ValidNegBinary = -0b101011101n;
-                                           ^^^^^^^^^^^^^ BigInt bigint literal \`-0b101011101n\` [1] is not yet supported.
-            References:
-              9:       type ValidNegBinary = -0b101011101n;
-                                             ^^^^^^^^^^^^^ [1]
-
-          test.js:11
-           11:       const valid_hex = 0xfff123n;
-                                       ^^^^^^^^^ BigInt bigint literal \`0xfff123n\` [1] is not yet supported.
-            References:
-             11:       const valid_hex = 0xfff123n;
-                                         ^^^^^^^^^ [1]
-
-          test.js:12
-           12:       const valid_neg_hex = -0xfff123n;
-                                            ^^^^^^^^^ BigInt bigint literal \`0xfff123n\` [1] is not yet supported.
-            References:
-             12:       const valid_neg_hex = -0xfff123n;
-                                              ^^^^^^^^^ [1]
-
-          test.js:13
-           13:       type ValidHex = 0xfff123n;
-                                     ^^^^^^^^^ BigInt bigint literal \`0xfff123n\` [1] is not yet supported.
-            References:
-             13:       type ValidHex = 0xfff123n;
-                                       ^^^^^^^^^ [1]
-
-          test.js:14
-           14:       type ValidNegHex = -0xfff123n;
-                                        ^^^^^^^^^^ BigInt bigint literal \`-0xfff123n\` [1] is not yet supported.
-            References:
-             14:       type ValidNegHex = -0xfff123n;
-                                          ^^^^^^^^^^ [1]
-
-          test.js:16
-           16:       const valid_large = 9223372036854775807n;
-                                         ^^^^^^^^^^^^^^^^^^^^ BigInt bigint literal \`9223372036854775807n\` [1] is not yet supported.
-            References:
-             16:       const valid_large = 9223372036854775807n;
-                                           ^^^^^^^^^^^^^^^^^^^^ [1]
-
-          test.js:17
-           17:       const valid_neg_large = -9223372036854775807n;
-                                              ^^^^^^^^^^^^^^^^^^^^ BigInt bigint literal \`9223372036854775807n\` [1] is not yet supported.
-            References:
-             17:       const valid_neg_large = -9223372036854775807n;
-                                                ^^^^^^^^^^^^^^^^^^^^ [1]
-
-          test.js:18
-           18:       type ValidLarge = 9223372036854775807n;
-                                       ^^^^^^^^^^^^^^^^^^^^ BigInt bigint literal \`9223372036854775807n\` [1] is not yet supported.
-            References:
-             18:       type ValidLarge = 9223372036854775807n;
-                                         ^^^^^^^^^^^^^^^^^^^^ [1]
-
-          test.js:19
-           19:       type ValidNegLarge = -9223372036854775807n;
-                                          ^^^^^^^^^^^^^^^^^^^^^ BigInt bigint literal \`-9223372036854775807n\` [1] is not yet supported.
-            References:
-             19:       type ValidNegLarge = -9223372036854775807n;
-                                            ^^^^^^^^^^^^^^^^^^^^^ [1]
-
-          test.js:21
-           21:       const valid_octal_new = 0o16432n;
-                                             ^^^^^^^^ BigInt bigint literal \`0o16432n\` [1] is not yet supported.
-            References:
-             21:       const valid_octal_new = 0o16432n;
-                                               ^^^^^^^^ [1]
-
-          test.js:22
-           22:       const valid_neg_octal_new = -0o16432n;
-                                                  ^^^^^^^^ BigInt bigint literal \`0o16432n\` [1] is not yet supported.
-            References:
-             22:       const valid_neg_octal_new = -0o16432n;
-                                                    ^^^^^^^^ [1]
-
-          test.js:23
-           23:       type ValidOctalNew = 0o16432n;
-                                          ^^^^^^^^ BigInt bigint literal \`0o16432n\` [1] is not yet supported.
-            References:
-             23:       type ValidOctalNew = 0o16432n;
-                                            ^^^^^^^^ [1]
-
-          test.js:24
-           24:       type ValidNegOctalNew = -0o16432n;
-                                             ^^^^^^^^^ BigInt bigint literal \`-0o16432n\` [1] is not yet supported.
-            References:
-             24:       type ValidNegOctalNew = -0o16432n;
-                                               ^^^^^^^^^ [1]
-
-          test.js:26
-           26:       const valid_small = 100n;
-                                         ^^^^ BigInt bigint literal \`100n\` [1] is not yet supported.
-            References:
-             26:       const valid_small = 100n;
-                                           ^^^^ [1]
-
-          test.js:27
-           27:       const valid_neg_small = -100n;
-                                              ^^^^ BigInt bigint literal \`100n\` [1] is not yet supported.
-            References:
-             27:       const valid_neg_small = -100n;
-                                                ^^^^ [1]
-
-          test.js:28
-           28:       type ValidSmall = 100n;
-                                       ^^^^ BigInt bigint literal \`100n\` [1] is not yet supported.
-            References:
-             28:       type ValidSmall = 100n;
-                                         ^^^^ [1]
-
-          test.js:29
-           29:       type ValidNegSmall = -1n;
-                                          ^^^ BigInt bigint literal \`-1n\` [1] is not yet supported.
-            References:
-             29:       type ValidNegSmall = -1n;
-                                            ^^^ [1]
-        `,
-      )
+    `).noNewErrors()
   ]),
 
   test("BigInt can be suppressed", [

newtests/sketchy_null/flowSketchyFile.js

@@ -12,4 +12,7 @@ function printSketchyBoolean(sketch: NullableType): void {
   if (sketch.nullableStr) {
     console.log(sketch.nullableStr);
   }
+  if (sketch.nullableBigInt) {
+    console.log(sketch.nullableBigInt);
+  }
 }

newtests/sketchy_null/flowStrictSketchyBigIntFile.js

@@ -0,0 +1,9 @@
+// @flow strict
+
+import type { NullableBigInt } from './flowTypeFile';
+
+function printSketchyNumber(sketch: NullableBigInt): void {
+  if (sketch.nullableBigInt) {
+    console.log(sketch.nullableBigInt);
+  }
+}

newtests/sketchy_null/flowStrictTypeFile.js

@@ -4,4 +4,5 @@ export type NullableType = {
   nullableStr?: string,
   nullableNum?: number,
   nullableBool?: boolean,
+  nullableBigInt?: bigint,
 };

newtests/sketchy_null/flowTypeFile.js

@@ -11,3 +11,7 @@ export type NullableNumber = {
 export type NullableBool = {
   nullableBool?: boolean,
 };
+
+export type NullableBigInt = {
+  nullableBigInt?: bigint,
+};

newtests/sketchy_null/test.js

@@ -28,6 +28,19 @@ export default suite(({addFiles, addCode, flowCmd}) => [
        `,
      ).exitCodes([]),
   ]),
+  test('should trigger sketchy null output on sketchy bigint', [
+    addFiles('flowTypeFile.js', 'flowStrictSketchyBigIntFile.js')
+    .newErrors(
+      `
+        flowStrictSketchyBigIntFile.js:6
+          6:   if (sketch.nullableBigInt) {
+                   ^^^^^^^^^^^^^^^^^^^^^ Sketchy null check on bigint [1] which is potentially 0n. Perhaps you meant to check for null or undefined [1]? (\`sketchy-null-bigint\`)
+          References:
+           16:   nullableBigInt?: bigint,
+                                  ^^^^^^ [1]. See: flowTypeFile.js:16
+      `,
+    ).exitCodes([]),
+  ]),
   test('should trigger sketchy null output on sketchy bool', [
     addFiles('flowTypeFile.js', 'flowStrictSketchyBooleanFile.js')
     .newErrors(

src/common/lints/lints.ml

@@ -9,6 +9,7 @@ type sketchy_null_kind =
   | SketchyNullBool
   | SketchyNullString
   | SketchyNullNumber
+  | SketchyNullBigInt
   | SketchyNullMixed
 
 type sketchy_number_kind =
@@ -37,6 +38,7 @@ let string_of_sketchy_null_kind = function
   | SketchyNullBool -> "sketchy-null-bool"
   | SketchyNullString -> "sketchy-null-string"
   | SketchyNullNumber -> "sketchy-null-number"
+  | SketchyNullBigInt -> "sketchy-null-bigint"
   | SketchyNullMixed -> "sketchy-null-mixed"
 
 let string_of_sketchy_number_kind = function
@@ -66,11 +68,13 @@ let kinds_of_string = function
       SketchyNull SketchyNullBool;
       SketchyNull SketchyNullString;
       SketchyNull SketchyNullNumber;
+      SketchyNull SketchyNullBigInt;
       SketchyNull SketchyNullMixed;
     ]
   | "sketchy-null-bool" -> Some [SketchyNull SketchyNullBool]
   | "sketchy-null-string" -> Some [SketchyNull SketchyNullString]
   | "sketchy-null-number" -> Some [SketchyNull SketchyNullNumber]
+  | "sketchy-null-bigint" -> Some [SketchyNull SketchyNullBigInt]
   | "sketchy-null-mixed" -> Some [SketchyNull SketchyNullMixed]
   | "sketchy-number" -> Some [
       SketchyNumber SketchyNumberAnd;

src/common/lints/lints.mli

@@ -9,6 +9,7 @@ type sketchy_null_kind =
  | SketchyNullBool
  | SketchyNullString
  | SketchyNullNumber
+ | SketchyNullBigInt
  | SketchyNullMixed
 
 type sketchy_number_kind =

src/common/ty/ty.ml

@@ -19,9 +19,11 @@ type t =
   | Bot of bot_kind
   | Void | Null
   | Num of string option
+  | BigInt of string option
   | Str of string option
   | Bool of bool option
   | NumLit of string
+  | BigIntLit of string
   | StrLit of string
   | BoolLit of bool
   | Fun of fun_t
@@ -257,7 +259,7 @@ let rec mk_exact ty =
   | Mu (i, t) -> Mu (i, mk_exact t)
   (* Not applicable *)
   | Any _ | Top | Bot _ | Void | Null
-  | Num _ | Str _ | Bool _ | NumLit _ | StrLit _ | BoolLit _
+  | Num _ | BigInt _ | Str _ | Bool _ | NumLit _ | BigIntLit _ | StrLit _ | BoolLit _
   | Fun _ | Arr _ | Tup _ -> ty
   (* Do not nest $Exact *)
   | Utility (Exact _) -> ty

src/common/ty/ty_debug.ml

@@ -153,6 +153,9 @@ and dump_t ?(depth = 10) t =
   | Num (Some x) -> spf "Num (%s)" x
   | Num None -> "Num"
   | NumLit s -> spf "\"%s\"" s
+  | BigInt (Some x) -> spf "BigInt (%s)" x
+  | BigInt None -> "BigInt"
+  | BigIntLit s -> spf "\"%s\"" s
   | Str (Some x) -> spf "Str (%s)" x
   | Str None -> "Str"
   | StrLit s -> spf "\"%s\"" s
@@ -205,9 +208,11 @@ let string_of_ctor = function
   | Void -> "Void"
   | Null -> "Null"
   | Num _ -> "Num"
+  | BigInt _ -> "BigInt"
   | Str _ -> "Str"
   | Bool _ -> "Bool"
   | NumLit _ -> "NumLit"
+  | BigIntLit _ -> "BigIntLit"
   | StrLit _ -> "StrLit"
   | BoolLit _ -> "BoolLit"
   | Fun _ -> "Fun"
@@ -258,8 +263,9 @@ let json_of_t ~strip_root =
     | Any Explicit -> [ "any", JSON_String "explicit" ]
     | Top | Bot _
     | Void | Null
-    | Num _ | Str _ | Bool _ -> []
+    | Num _ | BigInt _ | Str _ | Bool _ -> []
     | NumLit s
+    | BigIntLit s
     | StrLit s -> [
         "literal", JSON_String s
       ]

src/common/ty/ty_printer.ml

@@ -79,6 +79,7 @@ let type_ ?(size=5000) ?(with_comments=true) t =
     | Void -> Atom "void"
     | Null -> Atom "null"
     | Num _ -> Atom "number"
+    | BigInt _ -> Atom "bigint"
     | Str _ -> Atom "string"
     | Bool _ -> Atom "boolean"
     | Fun func ->
@@ -103,6 +104,7 @@ let type_ ?(size=5000) ?(with_comments=true) t =
         (counted_map (type_ ~depth) ts)
     | StrLit raw -> fuse (in_quotes raw)
     | NumLit raw -> Atom raw
+    | BigIntLit raw -> Atom raw
     | BoolLit value -> Atom (if value then "true" else "false")
     | TypeAlias ta -> type_alias ta
     | TypeOf (path, name) ->

src/common/ty/ty_serializer.ml

@@ -59,6 +59,10 @@ let rec type_ t =
     return (builtin_from_string "$TEMPORARY$number"
       ~targs:(Loc.none, [Loc.none, T.NumberLiteral (num_lit lit)]))
   | Num None -> just T.Number
+  | BigInt (Some lit) ->
+    return (builtin_from_string "$TEMPORARY$bigint"
+      ~targs:(Loc.none, [Loc.none, T.BigIntLiteral (bignum_lit lit)]))
+  | BigInt None -> just T.BigInt
   | Str (Some lit) ->
     return (builtin_from_string "$TEMPORARY$string"
       ~targs:(Loc.none, [Loc.none, T.StringLiteral (str_lit lit)]))
@@ -68,6 +72,7 @@ let rec type_ t =
       ~targs:(Loc.none, [Loc.none, (T.BooleanLiteral lit)]))
   | Bool None -> just T.Boolean
   | NumLit lit -> just (T.NumberLiteral (num_lit lit))
+  | BigIntLit lit -> just (T.BigIntLiteral (bignum_lit lit))
   | StrLit lit -> just (T.StringLiteral (str_lit lit))
   | BoolLit lit -> just (T.BooleanLiteral lit)
   | Fun f -> function_ f >>| fun f -> (Loc.none, T.Function f)
@@ -279,6 +284,12 @@ and num_lit lit = {
   raw = lit;
 }
 
+and bignum_lit lit = {
+  Ast.BigIntLiteral.
+  approx_value = (try Pervasives.float_of_string lit with Failure _ -> 0.);
+  bigint = lit;
+}
+
 and getter t = function_ {
   fun_params = [];
   fun_rest_param = None;

src/services/autocomplete/autocompleteService_js.ml

@@ -95,13 +95,13 @@ let lsp_completion_of_type (ty: Ty.t) =
   match ty with
   | Ty.InterfaceDecl _ -> Some Interface
   | Ty.ClassDecl _ -> Some Class
-  | Ty.(StrLit _ | NumLit _ | BoolLit _) -> Some Value
+  | Ty.(StrLit _ | NumLit _ | BigIntLit _ | BoolLit _) -> Some Value
   | Ty.Fun _ -> Some Function
   | Ty.TypeAlias _
   | Ty.Union _ -> Some Enum
   | Ty.Module _ -> Some Module
   | Ty.(Tup _ | Bot _ | Null | Obj _ | Inter _ | TVar _ | Bound _ | Generic _ |
-      Any _ | Top | Void | Num _ | Str _ | Bool _ | Arr _ | TypeOf _ |
+      Any _ | Top | Void | Num _ | BigInt _ | Str _ | Bool _ | Arr _ | TypeOf _ |
       Utility _ | Mu _
     ) ->  Some Variable
 

src/typing/coverage.ml

@@ -208,10 +208,12 @@ class visitor = object (self)
     | DefT (_, t, IdxWrapper _)
     | DefT (_, t, MixedT _)
     | DefT (_, t, NumT _)
+    | DefT (_, t, BigIntT _)
     | DefT (_, t, NullT)
     | DefT (_, t, ObjT _)
     | DefT (_, t, ReactAbstractComponentT _)
     | DefT (_, t, SingletonNumT _)
+    | DefT (_, t, SingletonBigIntT _)
     | DefT (_, t, SingletonStrT _)
     | DefT (_, t, SingletonBoolT _)
     | DefT (_, t, StrT _)