Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigInt typechecking #7602

Closed
wants to merge 23 commits into from
Closed

BigInt typechecking #7602

wants to merge 23 commits into from

Conversation

goodmind
Copy link
Contributor

@goodmind goodmind commented Mar 31, 2019 •
edited
Loading

Fixes #6639
Library definitions #7534 (BigInt builtin and typed arrays)

Probably signature verification should be rewritten too, but I don't know what it does.
There maybe missing cases in something like refinements, assignment operators (especially since they seem untyped)

Adds sketchy-null-bigint lint rule and supports bigint type in sketchy-number with different lint message

@goodmind goodmind changed the title Bigint typechecking BigInt typechecking Mar 31, 2019
goodmind
goodmind commented Mar 31, 2019
View reviewed changes
src/typing/statement.ml Outdated Show resolved Hide resolved
@goodmind
Copy link
Contributor Author

goodmind commented Apr 2, 2019 •
edited
Loading

Not sure why tests fail, it is something about lsp tests

@mvitousek
Copy link
Contributor

Is there a reason that the names "bigint" and "bignum" are inconsistently used? I'd personally rather align everything with "bigint" since (as far as I understand it) that's the actual Flow type being provided.

@goodmind
Copy link
Contributor Author

goodmind commented Apr 10, 2019 •
edited
Loading

@mvitousek just arbitrary, BigNum in typechecker, BigInt in AST, I just copypasted NumT with added Big 🙃

@goodmind
Copy link
Contributor Author

@mvitousek is this all that bothers you?

@goodmind
Copy link
Contributor Author

@mvitousek I renamed all of them to BigInt

@goodmind goodmind force-pushed the bigint-typecheck branch from accc410 to 33f0535 Compare June 7, 2019 07:54
goodmind added 21 commits July 10, 2019 09:57
@goodmind
[common] Add BigNum printers
c9c3879
@goodmind
[services] Add BigNum cases to autocomplete
42a681d
@goodmind
[typing] Add BigNumT constructor
a385d66
@goodmind
[typing] add typeof "bigint" check
cc848d4
@goodmind
[typing] Add BigInt operations
1d98730
@goodmind
[typing] Add sketchy-null-bigint check
0e1b2eb
@goodmind
[newtests] Add sketchy-null-bigint tests
974a51e
@goodmind
[typing] Add comparison for BigInt
4738172
@goodmind
[tests] Add BigInt to arith test
92b26ac
@goodmind
[website] Add docs about BigInt lint rules
3b3f7ab
@goodmind
[newtests] Update bigint test
cdde41b
@goodmind
[common] rename BigNum to BigInt
2f3d389
@goodmind
[typing] rename BIgNumT to BigIntT
86b3b31 
SingletonBigNumT to SingletonBIgIntT
BIgNumH to BigIntH
SingletonBIgNumH to SingletonBigIntH
@goodmind
[services] rename BigNumLit to BigIntLit
df998dc
@goodmind
[tests] rename BigNumT to BigIntT
a54ea43
@goodmind
[tests] Update arith snapshot
ab4aea4
@goodmind
[typing] Add missing bigint assert match
a01d9bb
@goodmind
[typing] Specify Bottom argument to EmptyT
9fa715b
@goodmind
[typing] Add TODOs to update and op_assignment
07c4a64
@goodmind
[typing] Generalize AdderT to ArithmeticBInaryT and ArithmeticUnaryT
bb7b2b0
@goodmind
[tests] Update arith tests
fc35e3d
@goodmind goodmind mentioned this pull request Jul 18, 2019
Closed
@samwgoldman samwgoldman mentioned this pull request Jul 26, 2019
Closed
64 tasks
facebook-github-bot
facebook-github-bot reviewed Dec 12, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvitousek has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

chicoxyzzy
chicoxyzzy reviewed Mar 31, 2020
View reviewed changes
src/typing/type.ml

| BoolP (* boolean *)
| FunP (* function *)
| NumP (* number *)
| BIgIntP (* bigint *)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| BIgIntP (* bigint *)
| BigIntP (* bigint *)

src/typing/debug_js.ml
@@ -22,13 +22,15 @@ let string_of_pred_ctor = function
| BoolP -> "BoolP"
| StrP -> "StrP"
| NumP -> "NumP"
| BIgIntP -> "BIgIntP"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| BIgIntP -> "BIgIntP"
| BigIntP -> "BigIntP"

src/typing/debug_js.ml
@@ -1388,6 +1400,7 @@ and json_of_pred_impl json_cx p = Hh_json.(
| StrP
| SymbolP
| NumP
| BIgIntP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| BIgIntP
| BigIntP

src/typing/flow_js.ml
(* typeof _ ~ "bigint" *)
(***********************)

| BIgIntP ->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| BIgIntP ->
| BigIntP ->

src/typing/flow_js.ml
| BIgIntP ->
rec_flow_t cx trace (Type_filter.bigint l, t)

| NotP BIgIntP ->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| NotP BIgIntP ->
| NotP BigIntP ->

src/typing/statement.ml
@@ -5537,6 +5649,7 @@ and predicates_of_condition cx e = Ast.(Expression.(
| "boolean" -> Some BoolP
| "function" -> Some FunP
| "number" -> Some NumP
| "bigint" -> Some BIgIntP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| "bigint" -> Some BIgIntP
| "bigint" -> Some BigIntP

newtests/bigint/test.js
@@ -201,156 +201,7 @@ export default suite(({ addFile, addFiles, addCode }) => [
const valid_neg_small = -100n;
type ValidSmall = 100n;
type ValidNegSmall = -1n;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests for BigInts with numeric separators are missing here. Parser already support them.

@mroch mroch added the ES2020 label Apr 16, 2020
@isker isker mentioned this pull request Jul 8, 2020
Closed
@gkz
Copy link
Member

gkz commented Dec 14, 2022

BigInt is now supported as of 0.194

@gkz gkz closed this Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@chicoxyzzy chicoxyzzy chicoxyzzy left review comments

Assignees
No one assigned
Labels
CLA Signed ES2020
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add support for new type: bigint
6 participants
@goodmind @mvitousek @gkz @chicoxyzzy @facebook-github-bot @mroch