make ViewController nullable param in reauthorizeDataAccess #2477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuriy-tolstoguzov
approved these changes
Dec 11, 2024
|
@yuriy-tolstoguzov has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@yuriy-tolstoguzov merged this pull request in a5ae682. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help us review the request, please complete the following:
bugfor bug fixes)Pull Request Details
👋 hello from the react-native-fbsdk-next maintainer 😄
I would like the
reauthorizeDataAccessViewController param to conform to the nullability documented for it, and acceptable to the methods it passes the param toTest Plan
Untested (not entirely true, we've been actively sending nil through this API since our first implementation using the API, and it's worked fine)
Fixes #2476