-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow specifying custom target for FooterLogo #7557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, very timely PR 😄
packages/docusaurus-theme-classic/src/theme/Footer/Logo/index.tsx
Outdated
Show resolved
Hide resolved
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍 LGTM
Pre-flight checklist
Motivation
In the current documentation, it says Customization of the logo object. See Navbar logo for details, but it's not allowed to add a footer logo target.
This issue has been raised before in this PR #2344, it's available to specify a target only for the navbar logo.
It would be great if it works for the footer logo as well.
Test Plan
footer.logo.href
property, and set thefooter.logo.target
property to "_self" - make sure that the external link opens in the current tab. This use case is the main goal of PR.Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs