feat(v2): allow specifying custom target for logo link #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit e6768af |
yangshun
approved these changes
Feb 29, 2020
yangshun
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolve #2339.
This is really useful if users are hosting a website with documentation in a subdirectory of the main site (baseUrl has been changed) and therefore the '/' link will lead to a 404 error (read comments of the issue).
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Set the external link for the
navbar.logo.hrefproperty, and set thenavbar.logo.targetproperty to "_self" - make sure that the external link opens in the current tab (thus, we override the default value when the external link opens in a new tab). This use case is the main goal of PR.In contrast to the first item, set the
navbar.logo.hrefproperty to some internal link, and put "_blank" in thenavbar.logo.targetproperty, now the internal link should open in a new tab.Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)