Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: avoid using fs.realpathSync in website #7496

Merged
merged 2 commits into from
May 26, 2022
Merged

misc: avoid using fs.realpathSync in website #7496

merged 2 commits into from
May 26, 2022

Conversation

Zamiell
Copy link
Contributor

@Zamiell Zamiell commented May 26, 2022

fixes yarn start, from @Josh-Cena

@facebook-github-bot
Copy link
Contributor

Hi @Zamiell!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@Josh-Cena Josh-Cena changed the title dogfood fix misc: avoid using fs.realpathSync in website May 26, 2022
@Josh-Cena Josh-Cena added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label May 26, 2022
@Josh-Cena
Copy link
Collaborator

For context: this doesn't work on virtually every Windows machine. See #7052 for one.

fs.realpathSync is really not very useful because it just points to the original directory. We may well just use the original one, then.

@netlify
Copy link

netlify bot commented May 26, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit f71466f
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/628efada9ffc9100081563fc
😎 Deploy Preview https://deploy-preview-7496--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 26, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 83 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 85 🟢 99 🟢 100 🟢 100 🟢 90 Report

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 26, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Josh-Cena Josh-Cena merged commit 89ddc6d into facebook:main May 26, 2022
@Zamiell Zamiell deleted the dogfood-fix branch May 26, 2022 07:09
@slorber
Copy link
Collaborator

slorber commented May 26, 2022

I don't understand, how do we test for our symlinked dir support now?

@Josh-Cena
Copy link
Collaborator

Josh-Cena commented May 26, 2022

How is fs.realpathSync testing anything in practice, though? It always evaluates to "_dogfooding/_docs tests" on machines that support it. On machines that don't support symlinks (i.e. all Windows machines), it always causes an obscure error that I have to teach them to fix. Previously when we had resolve.symlinks: false for Webpack, it seems more worthwhile to test, but now, it's simply not an API of ours anymore, more like a user-land workaround.

@slorber
Copy link
Collaborator

slorber commented May 26, 2022

ok 👍 true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants