Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: avoid using fs.realpathSync in website #7496

Merged
merged 2 commits into from
May 26, 2022
Merged

misc: avoid using fs.realpathSync in website #7496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
313a481
dogfood fix
Zamiell May 26, 2022
f71466f
remove other mentions
Josh-Cena May 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion website/_dogfooding/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ Eventually, we could move these tests later so another test site? Note there is
Fancy things we can test for here:

- Plugin Multi-instance
- Symlinks support
- Webpack configs
- \_ prefix convention
- Huge sidebars impact
Expand Down
1 change: 0 additions & 1 deletion website/_dogfooding/docs-tests-symlink
View file
Open in desktop

This file was deleted.

8 changes: 2 additions & 6 deletions website/_dogfooding/dogfooding.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
* LICENSE file in the root directory of this source tree.
*/

const fs = require('fs');

/** @type {import('@docusaurus/types').PluginConfig[]} */
const dogfoodingThemeInstances = [
/** @type {import('@docusaurus/types').PluginModule} */
Expand All @@ -29,10 +27,8 @@ const dogfoodingPluginInstances = [
routeBasePath: '/tests/docs',
sidebarPath: '_dogfooding/docs-tests-sidebars.js',

// Using a symlinked folder as source, test for use-case https://github.com/facebook/docusaurus/issues/3272
// The target folder uses a _ prefix to test against an edge case regarding MDX partials: https://github.com/facebook/docusaurus/discussions/5181#discussioncomment-1018079
// eslint-disable-next-line no-restricted-properties
path: fs.realpathSync('_dogfooding/docs-tests-symlink'),
// Using a _ prefix to test against an edge case regarding MDX partials: https://github.com/facebook/docusaurus/discussions/5181#discussioncomment-1018079
path: '_dogfooding/_docs tests',
showLastUpdateTime: true,
sidebarItemsGenerator(args) {
return args.defaultSidebarItemsGenerator({
Expand Down