Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(theme-translations): complete French translations #7493

Merged
merged 3 commits into from
May 26, 2022
Merged

chore(theme-translations): complete French translations #7493

merged 3 commits into from
May 26, 2022

Conversation

forresst
Copy link
Contributor

Pre-flight checklist

Motivation

Docusaurus in french is better 😄

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 25, 2022
@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label May 25, 2022
@Josh-Cena Josh-Cena changed the title Translate plugin-ideal-image.json in french chore(theme-translations): complete French translations May 25, 2022
@netlify
Copy link

netlify bot commented May 25, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit ce9bbe3
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/628e0e3b621f97000800f59e
😎 Deploy Preview https://deploy-preview-7493--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 25, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 84 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 84 🟢 99 🟢 100 🟢 100 🟢 90 Report

@Josh-Cena
Copy link
Collaborator

@forresst In case you aren't aware, you can press . on any page (e.g. your forked https://github.com/forresst/docusaurus) to open up a VS Code instance in your browser so that you can edit all the files and commit them all in one go.

@forresst forresst marked this pull request as ready for review May 25, 2022 11:25
@slorber
Copy link
Collaborator

slorber commented May 26, 2022

LGTM thanks 👍

@forresst In case you aren't aware, you can press . on any page (e.g. your forked forresst/docusaurus) to open up a VS Code instance in your browser so that you can edit all the files and commit them all in one go.

🤯 totally missed that! thanks

@slorber slorber merged commit 06a3711 into facebook:main May 26, 2022
@forresst forresst deleted the patch-4 branch May 26, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants