Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): inject docusaurus version into SSR as local #7329

Merged
merged 2 commits into from
May 5, 2022
Merged

fix(core): inject docusaurus version into SSR as local #7329

merged 2 commits into from
May 5, 2022

Conversation

RDIL
Copy link
Contributor

@RDIL RDIL commented May 4, 2022

Bug caused by #7187

This commit causes all sorts of issues because webpack can't analyze the package.json entry.

E.g.:

[WARNING] {"moduleIdentifier":"/home/bodell/Documentation/node_modules/@babel/core/lib/config/files/configuration.js","moduleName":"./node_modules/@babel/core/lib/config/files/configuration.js","loc":"163:150-157","message":"Critical dependency: require function is used in a way in which dependencies cannot be statically extracted","compilerPath":"server"}
[WARNING] {"moduleIdentifier":"/home/bodell/Documentation/node_modules/@babel/core/lib/config/files/import.js","moduleName":"./node_modules/@babel/core/lib/config/files/import.js","loc":"9:9-25","message":"Critical dependency: the request of a dependency is an expression","compilerPath":"server"}
[WARNING] {"moduleIdentifier":"/home/bodell/Documentation/node_modules/browserslist/node.js","moduleName":"./node_modules/browserslist/node.js","loc":"171:18-76","message":"Critical dependency: the request of a dependency is an expression","compilerPath":"server"}
[WARNING] {"moduleIdentifier":"/home/bodell/Documentation/node_modules/browserslist/node.js","moduleName":"./node_modules/browserslist/node.js","loc":"171:26-33","message":"Critical dependency: require function is used in a way in which dependencies cannot be statically extracted","compilerPath":"server"}

By injecting it, the deploy preview log no longer shows the errors: https://app.netlify.com/sites/docusaurus-2/deploys/627322423fef010008c50bb6

@RDIL RDIL requested review from slorber, lex111 and Josh-Cena as code owners May 4, 2022 19:31
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 4, 2022
@netlify
Copy link

netlify bot commented May 4, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 1645290
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/627322423fef010008c50bb6
😎 Deploy Preview https://deploy-preview-7329--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 4, 2022

⚡️ Lighthouse report for the changes in this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 63 🟢 100 🟢 100 🟢 100 🟢 90 View report
/docs/installation 🟠 82 🟢 96 🟢 100 🟢 100 🟢 90 View report

@Josh-Cena Josh-Cena changed the title fix(core): Revert "handle case where package.json is not available at CWD" fix(core): inject docusaurus version into SSR as local May 5, 2022
@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label May 5, 2022
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remaining warning in our log is unrelated and quite intractable to fix. Thanks for narrowing down to the real cause!

@Josh-Cena Josh-Cena merged commit d3f526f into facebook:main May 5, 2022
@slorber
Copy link
Collaborator

slorber commented May 5, 2022

great 👍

@Josh-Cena
Copy link
Collaborator

Josh-Cena commented May 5, 2022

@slorber Do you think this is worth a hotfix release? It'll likely confuse other users, although it's not actually critical (because it's the server build). We'll have to wait for another month otherwise.

@slorber
Copy link
Collaborator

slorber commented May 5, 2022

yes I'll likely do one, hopefully all important bugs will be reported before the end of the day

otherwise I can still do a release later but I'd prefer not to

@Josh-Cena
Copy link
Collaborator

Yes, let's collect some more feedback... 'Bit unfortunate it's either today or half a month later

@RDIL RDIL deleted the revert-7187-jc/site-version branch May 5, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants