fix(core): handle case where package.json is not available at CWD #7187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-7187--docusaurus-2.netlify.app/ |
|
Size Change: +117 B (0%) Total Size: 799 kB
ℹ️ View Unchanged
|
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
|
We could have used |
slorber
requested changes
Apr 20, 2022
Josh-Cena
added a commit
that referenced
this pull request
May 5, 2022
* Revert "fix(core): handle case where package.json is not available at CWD (#7187)" This reverts commit 3b32a41. * properly fix Co-authored-by: Joshua Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #7161. Moreover, this PR adds a
DOCUSAURUS_VERSIONenv so that different modules can read this version without re-importing the package.json file.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Delete
website/package.json, and add"dev": "cd website && docusaurus start",to the root package.json. The site starts gracefully: