Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): collocate CLI commands and their option types #7292

Merged
merged 2 commits into from
May 3, 2022

Conversation

Josh-Cena
Copy link
Collaborator

@Josh-Cena Josh-Cena commented May 3, 2022

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

  1. Makes the types package smaller
  2. Reduces duplication of different overlapping types
  3. Renamed loadContext's options to match the CLI options
  4. Fixed a little type bug with DeployCLIOptions, which used to be treated the same as BuildCLIOptions (while it's in fact not allowing --no-minify and --bundle-analyzer)

Test Plan

Still builds

@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label May 3, 2022
@Josh-Cena Josh-Cena requested review from slorber and lex111 as code owners May 3, 2022 07:06
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 3, 2022
@netlify
Copy link

netlify bot commented May 3, 2022

[V2]

Name Link
🔨 Latest commit 070a1f1
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6270d766b4c100000888f2af
😎 Deploy Preview https://deploy-preview-7292--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 3, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 62
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7292--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena force-pushed the jc/refactor-command-option-types branch from 4045ce3 to 070a1f1 Compare May 3, 2022 07:19
@github-actions
Copy link

github-actions bot commented May 3, 2022

Size Change: 0 B

Total Size: 805 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 50.5 kB
website/build/assets/css/styles.********.css 107 kB
website/build/assets/js/main.********.js 609 kB
website/build/index.html 38.8 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit c7a5af7 into main May 3, 2022
@Josh-Cena Josh-Cena deleted the jc/refactor-command-option-types branch May 3, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants