fixes

facebook · May 3, 2022 · 070a1f1 · 070a1f1
1 parent 2d904eb
commit 070a1f1
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 44 deletions.
diff --git a/packages/docusaurus/src/commands/commandUtils.ts b/packages/docusaurus/src/commands/commandUtils.ts
diff --git a/packages/docusaurus/src/commands/serve.ts b/packages/docusaurus/src/commands/serve.ts
@@ -12,11 +12,7 @@ import path from 'path';
 import type {LoadContextOptions} from '../server';
 import {loadSiteConfig} from '../server/config';
 import {build} from './build';
-import {
-  getCLIOptionHost,
-  getCLIOptionPort,
-  type HostPortOptions,
-} from './commandUtils';
+import {getHostPort, type HostPortOptions} from '../server/getHostPort';
 import {DEFAULT_BUILD_DIR_NAME} from '@docusaurus/utils';
 
 export type ServeCLIOptions = HostPortOptions &
@@ -43,8 +39,7 @@ export async function serve(
     );
   }
 
-  const host: string = getCLIOptionHost(cliOptions.host);
-  const port: number | null = await getCLIOptionPort(cliOptions.port, host);
+  const {host, port} = await getHostPort(cliOptions);
 
   if (port === null) {
     process.exit();

diff --git a/packages/docusaurus/src/commands/start.ts b/packages/docusaurus/src/commands/start.ts
@@ -24,11 +24,7 @@ import {
   applyConfigurePostCss,
   getHttpsConfig,
 } from '../webpack/utils';
-import {
-  getCLIOptionHost,
-  getCLIOptionPort,
-  type HostPortOptions,
-} from './commandUtils';
+import {getHostPort, type HostPortOptions} from '../server/getHostPort';
 import {getTranslationsLocaleDirPath} from '../server/translations/translations';
 
 export type StartCLIOptions = HostPortOptions &
@@ -60,8 +56,7 @@ export async function start(
 
   const protocol: string = process.env.HTTPS === 'true' ? 'https' : 'http';
 
-  const host: string = getCLIOptionHost(cliOptions.host);
-  const port: number | null = await getCLIOptionPort(cliOptions.port, host);
+  const {host, port} = await getHostPort(cliOptions);
 
   if (port === null) {
     process.exit();

diff --git a/packages/docusaurus/src/server/choosePort.ts → ...ages/docusaurus/src/server/getHostPort.ts b/packages/docusaurus/src/server/choosePort.ts → ...ages/docusaurus/src/server/getHostPort.ts
@@ -8,6 +8,7 @@
 import {execSync, type ExecSyncOptionsWithStringEncoding} from 'child_process';
 import detect from 'detect-port';
 import logger from '@docusaurus/logger';
+import {DEFAULT_PORT} from '@docusaurus/utils';
 import prompts from 'prompts';
 
 const execOptions: ExecSyncOptionsWithStringEncoding = {
@@ -48,7 +49,7 @@ function getProcessForPort(port: number): string | null {
  * port is already being used. This feature was heavily inspired by
  * create-react-app and uses many of the same utility functions to implement it.
  */
-export async function choosePort(
+async function choosePort(
   host: string,
   defaultPort: number,
 ): Promise<number | null> {
@@ -85,3 +86,18 @@ Would you like to run the app on another port instead?`),
     throw err;
   }
 }
+
+export type HostPortOptions = {
+  host?: string;
+  port?: string;
+};
+
+export async function getHostPort(options: HostPortOptions): Promise<{
+  host: string;
+  port: number | null;
+}> {
+  const host = options.host ?? 'localhost';
+  const basePort = options.port ? parseInt(options.port, 10) : DEFAULT_PORT;
+  const port = await choosePort(host, basePort);
+  return {host, port};
+}
diff --git a/packages/docusaurus/src/server/plugins/__tests__/init.test.ts b/packages/docusaurus/src/server/plugins/__tests__/init.test.ts
@@ -37,9 +37,7 @@ describe('initPlugins', () => {
 
   it('throws user-friendly error message for plugins with bad values', async () => {
     await expect(() =>
-      loadSite({
-        customConfigFilePath: 'badPlugins.docusaurus.config.js',
-      }),
+      loadSite({config: 'badPlugins.docusaurus.config.js'}),
     ).rejects.toThrowErrorMatchingSnapshot();
   });
 });