Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: tighten CI trigger conditions #7279

Merged
merged 1 commit into from
Apr 30, 2022
Merged

misc: tighten CI trigger conditions #7279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-blog-only.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
branches:
- main
paths:
- packages/docusaurus/**
- packages/**

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/build-perf.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,10 @@ on:
pull_request:
branches:
- main
paths-ignore:
- website/docs/**
paths:
- packages/**
- website/**
- '!website/docs/**'

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/tests-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,15 @@ on:
push:
branches:
- main
paths-ignore:
- website/**
paths:
- packages/**
- tsconfig.json
pull_request:
branches:
- main
paths-ignore:
- website/**
paths:
- packages/**
- tsconfig.json

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/tests-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@ on:
pull_request:
branches:
- main
paths-ignore:
- website/**
paths:
- packages/**
- tsconfig.json

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@ on:
pull_request:
branches:
- main
paths-ignore:
- website/**
paths:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we want CI to run again if project deps changes? (ie lockfile)

Copy link
Collaborator Author

@Josh-Cena Josh-Cena May 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it, but I can't think of a case where lockfile changes without package.json changing as well. Because if package.json doesn't change, there will be no difference to our user anyways.

Copy link
Collaborator

@slorber slorber May 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can upgrade Yarn package resolutions and yet keep package.json intact, as long as semver ranges is respected

It's not what we do in practice when we upgrade deps so we can give it a try like that and see if it causes any problem 👍

- packages/**
- tsconfig.json

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
Expand Down