-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: tighten CI trigger conditions #7279
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-7279--docusaurus-2.netlify.app/ |
@@ -4,8 +4,9 @@ on: | |||
pull_request: | |||
branches: | |||
- main | |||
paths-ignore: | |||
- website/** | |||
paths: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we want CI to run again if project deps changes? (ie lockfile)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about it, but I can't think of a case where lockfile changes without package.json changing as well. Because if package.json doesn't change, there will be no difference to our user anyways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can upgrade Yarn package resolutions and yet keep package.json intact, as long as semver ranges is respected
It's not what we do in practice when we upgrade deps so we can give it a try like that and see if it causes any problem 👍
Pre-flight checklist
Motivation
The test actions trigger too frequently, even for root files like
project-words.txt
that don't actually impact users. I decided to confine everything topackages/**
only.