Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: tighten CI trigger conditions #7279

Merged
merged 1 commit into from
Apr 30, 2022
Merged

misc: tighten CI trigger conditions #7279

merged 1 commit into from
Apr 30, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

The test actions trigger too frequently, even for root files like project-words.txt that don't actually impact users. I decided to confine everything to packages/** only.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 30, 2022
@netlify
Copy link

netlify bot commented Apr 30, 2022

[V2]

Name Link
🔨 Latest commit 34dfdb9
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/626d42cacb04e300098478ab
😎 Deploy Preview https://deploy-preview-7279--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 60
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7279--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena merged commit 3c24cbc into main Apr 30, 2022
@Josh-Cena Josh-Cena deleted the jc/tighten-actions branch April 30, 2022 14:17
@@ -4,8 +4,9 @@ on:
pull_request:
branches:
- main
paths-ignore:
- website/**
paths:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we want CI to run again if project deps changes? (ie lockfile)

Copy link
Collaborator Author

@Josh-Cena Josh-Cena May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it, but I can't think of a case where lockfile changes without package.json changing as well. Because if package.json doesn't change, there will be no difference to our user anyways.

Copy link
Collaborator

@slorber slorber May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can upgrade Yarn package resolutions and yet keep package.json intact, as long as semver ranges is respected

It's not what we do in practice when we upgrade deps so we can give it a try like that and see if it causes any problem 👍

@Josh-Cena Josh-Cena added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants