fix(theme-classic): fix breadcrumb home link bug with new useHomePageRoute() hook

[slorber]

Motivation

See also #6517 (comment)

Breadcrumbs link to the home by default:

Sometimes a site does not have a homepage, so it's not possible to link by default to / from the breadcrumbs home icon (lead to broken links error).

In such cases we can simply remove the home item from breadcrumbs, until we find a better solution (see suggestions in #6517 (comment))

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

unit tests + local tests without home page or with docs/blog-only-home

[netlify]

✔️ [V2]

🔨 Explore the source changes: 64579f7

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/621665eecc5ad3000817ef43

😎 Browse the preview: https://deploy-preview-6749--docusaurus-2.netlify.app

[github-actions]

⚡️ Lighthouse report for the changes in this PR:

Category	Score
🟠 Performance	57
🟢 Accessibility	100
🟢 Best practices	92
🟢 SEO	100
🟢 PWA	90

Lighthouse ran on https://deploy-preview-6749--docusaurus-2.netlify.app/

[github-actions]

Size Change: +358 B (0%)

Total Size: 782 kB

Filename	Size	Change
website/build/assets/js/main.********.js	591 kB	+358 B (0%)

ℹ️ View Unchanged

Filename	Size
website/.docusaurus/globalData.json	48 kB
website/build/assets/css/styles.********.css	106 kB
website/build/index.html	37.6 kB

_{compressed-size-action}

[PatelN123]

@slorber Might be a dumb idea, but how about instead of removing it fully, giving the user an option to set a home URL? Maybe in the config file...

[slorber]

That is an idea, but IMHO it's better if sites have a homepage so maybe we should encourage to have one instead?

We have other places where we link to this homepage, including the navbar logo:

const logoLink = useBaseUrl(logo.href || '/');

[PatelN123]

That's a point.
I just thought with the scenario we had with the Chatwoot docs, it may be a neat idea.

[pranabdas]

@slorber what about sites with baseUrl? In beta 16, the home icon is not shown in the breadcrumbs in this case. I suppose it should be there linking to /baseUrl/ 🤔

[slorber]

@pranabdas you are right it's a silly mistake 😅 will fix it on Wednesday unless someone wants to handle it before