-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: breadcrumbs #220
feat: breadcrumbs #220
Conversation
I think this is failing due to the sidebar configuration. |
I'm noted. I'll inspect this—could be a Docusaurus regression |
Thanks, I knew you'd be able to figure it out. |
The issue is exactly related to the breadcrumbs. The breadcrumbs, by default, contains a link to the "home page", which is https://www.chatwoot.com/docs – which is non-existent. Docusaurus doesn't know that this link re-directs and simply reports that it doesn't exist. @slorber Do you think we should simply apply @PatelN123 I don't think you should upgrade the site to canary version just for a certain feature. Just wait until the stable release is out (which should be next week—we release about every month). |
That's annoying 😅 A quickfix would be to use This means https://www.chatwoot.com/docs/self-hosted would become https://www.chatwoot.com/docs/ (and you should remove the server redirect): not sure it's something you want.
The redirect is server-side, so if we navigate with It'd say we can first apply Maybe we could find a heuristic so that there's always a site homepage to redirect to? (docs or blog for example) Maybe we should hide the home item if we detect the site has no homepage? Let's continue this discussion in facebook/docusaurus#6517 (comment)
On the contrary I think it's good for us and actually, help us see these kinds of bugs earlier :D |
@slorber Thanks for taking a look at the PR.
We already had /help-center on our marketing website, didn't want to duplicate it. I guess we could move it to Docusaurus instead of keeping it there. It would be easier that way to get this upgrade completed. Glad that we found the bug early. :) @PatelN123 Thanks for the upgrade and the proactive communication on this. |
👍 imho you can keep /help-center in your gatsby site, you just need a real page at /docs |
the current canary should now build fine without changing anything |
Thanks @slorber, I'll give it a go! |
@PatelN123 @slorber Thanks for the work, merging this as the update is working as expected. |
Adds the new breadcrumbs feature!