Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): update @docsearch/react #5135

Merged
merged 1 commit into from
Jul 9, 2021
Merged

chore(v2): update @docsearch/react #5135

merged 1 commit into from
Jul 9, 2021

Conversation

shortcuts
Copy link
Contributor

Motivation

Bump DocSearch version to the latest, which fixes #5031

Summary

Without query, recent searches and favorite searches, pressing crashes the website.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview

upgrade-docsearch-deps.mov

@shortcuts shortcuts requested review from lex111 and slorber as code owners July 9, 2021 15:13
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 9, 2021
@netlify
Copy link

netlify bot commented Jul 9, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: a39fb1d

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60e867b866ec6a0007a208e8

😎 Browse the preview: https://deploy-preview-5135--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Jul 9, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 73
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5135--docusaurus-2.netlify.app/

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jul 9, 2021
@slorber
Copy link
Collaborator

slorber commented Jul 9, 2021

seems to work thanks 👍

@slorber slorber merged commit 7babfe0 into facebook:master Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arrow up causing crashed when using @docusaurus/theme-search-algolia
3 participants