arrow up causing crashed when using @docusaurus/theme-search-algolia

[vagusX]

🐛 Bug Report

Prerequisites

• I'm using the latest version of Docusaurus.
• I have tried the npm run clear or yarn clear command.
• I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
• I have tried creating a repro with https://new.docusaurus.io
• I have read the console error message carefully (if applicable)

Description

(A clear and concise description of what the bug is.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Steps to reproduce

Use https://new.docusaurus.io to create a CodeSandbox reproducible demo of the bug.

(Write your steps here:)

1. Press Cmd + K
2. Press ↑ (arrow up)
3. Page is crashed

Expected behavior

No crashing

(Write what you thought would happen.)

Actual behavior

(Write what happened. Add full console log messages and screenshots, if applicable.)

Your environment

• Public source code:
• Public site URL:
• Docusaurus version used:
• Environment name and version (e.g. Chrome 78.0.3904.108, Node.js 10.17.0):
• Operating system and version (e.g. Ubuntu 20.04.2 LTS):

Reproducible demo

https://docusaurus.io/docs/api/themes/@docusaurus/theme-search-algolia

[slorber]

@vagusX I'm sorry but I can't reproduce on that page

https://docusaurus.io/docs/api/themes/@docusaurus/theme-search-algolia

As this issue has been reported first on the Ant design website (apparently), why are you reporting it to Docusaurus? Ant Design website is not using Docusaurus. I can reproduce it on the Ant design website, not on Docusaurus website.

@shortcuts is this issue known?

[shortcuts]

Hi,

I'm not able to reproduce this issue in an up-to-date DocSearch v3 experience (with ant design index https://2ppfv.csb.app/)

@slorber do you have a link where I could see the issue on the Ant design website?

@vagusX if you can still reproduce on your side, could you please let me know which User Agents are sent with the query? They should contain the version of the DocSearch and Autocomplete library, which might gives a hint.

[slorber]

I can reproduce it on the url reported here ant-design/ant-design#31040: https://ant.design/

[vagusX]

@slorber would you like to clean all recent items and try it again?

[vagusX]

Same issue @shortcuts

The component version is here https://github.com/facebook/docusaurus/blob/master/packages/docusaurus-theme-search-algolia/package.json#L16

I just found the code is archived https://github.com/francoischalifour/autocomplete.js/blob/ds-react/src/DocSearchModal.tsx (the latest code is different with @docsearch/[email protected])

I just wonder where is @docsearch/react source code repo? @francoischalifour told me that should fire a issue at the repo?

[shortcuts]

Yep the repo of the underlying library is now https://github.com/algolia/autocomplete, thanks for pointing that out! The PR I've opened (algolia/autocomplete#599) will also fix this issue.

[vagusX]

Yep the repo of the underlying library is now algolia/autocomplete, thanks for pointing that out! The PR I've opened (algolia/autocomplete#599) will also fix this issue.

Wow, just looking forward for this fix pr release.

@shortcuts would you like to tell that when your pr ship out.

[gearcoded]

To reproduce the issue, you need to open the search popup and make sure that no entries are displayed. If there are previous search entries, you can remove them.
Then press the Up Arrow and the page will crash.

[shortcuts]

Update: this PR has been merged but didn't solved the DocSearch issue, I've found an other related issue which should solve it: algolia/autocomplete#623

The DocSearch update will be released by the end of the week!