fix(v2): Show dropdown instead of a single button when there are two versions #3472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 57ef649 |
SamChou19815
added a commit
to cornell-dti/trends-in-web-dev-website
that referenced
this pull request
Sep 22, 2020
There is a bug in the dropdown component, which I'm fixing in facebook/docusaurus#3472 Meanwhile, I swizzled the buggy component and applied my fix.
|
@SamChou19815 thanks! |
SamChou19815
added a commit
to cornell-dti/trends-in-web-dev-website
that referenced
this pull request
Sep 22, 2020
…le (#131) There is a bug in the dropdown component, which I'm fixing in facebook/docusaurus#3472 Meanwhile, I swizzled the buggy component and applied my fix.
|
Agree 😉 my mistake
Le mar. 22 sept. 2020 à 16:21, Alexey Pyltsyn <[email protected]> a
écrit :
… @SamChou19815 <https://github.com/SamChou19815> thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3472 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFW6PX6IETQKANEEQWFVTDSHC6GZANCNFSM4RV4LESQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Comment above the code says that
We don't want to render a version dropdown with 0 or 1 item. However, the check below also include the case when we have 2 versions. I believe that this is a bug since we still want to show dropdown when there are two versions.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Tested locally with only two versions left: current and alpha-64:
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)