Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2] Versioning Dropdown doesn't show "Next" version #3487

Closed
greghesp opened this issue Sep 26, 2020 · 9 comments
Closed

[V2] Versioning Dropdown doesn't show "Next" version #3487

greghesp opened this issue Sep 26, 2020 · 9 comments
Labels
bug An error in the Docusaurus core causing instability or issues with its execution closed: duplicate This issue or pull request already exists in another issue or pull request

Comments

@greghesp
Copy link

🐛 Bug Report

type: 'docsVersionDropdown', position: 'left' is not showing as a dropdown with Current Version and Next

This produced by 3.x.x documents fine, and when i yarn start they show u

Have you read the Contributing Guidelines on issues?

Yes

To Reproduce

  1. Run docusaurus docs:version 3.x.x - 3.x.x folders, sidebars and versions.json created
  2. Modify /docs for in development version
  3. Run docusaurus start
  4. Check Navigation bar for dropdown

Expected behavior

Expected dropdown to be in Navbar
image

Actual Behavior

Navigation bar only shows the latest version with no dropdown.
image

URLs to the next documentation however work

/docs/next/introduction - shows documentation with the unreleased documentation warning. Shows Next in place of dropdown

/docs/introduction - shows versioned documentation with version tag. Shows version in place of dropdown

Your Environment

  • Docusaurus version used: 2.0.0-alpha.64
  • Environment name and version (e.g. Chrome 78.0.3904.108, Node.js 10.17.0): Chrome 85.0.4183.121, Node 10.15.1
  • Operating system and version (desktop or mobile): MacOS 10.15.7

Reproducible Demo

https://assistantrelay.com/
https://github.com/greghesp/assistant-relay/tree/doc-src

@greghesp greghesp added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Sep 26, 2020
@lex111
Copy link
Contributor

lex111 commented Sep 26, 2020

Already fixed in #3472 but thank you for the report.

@lex111 lex111 closed this as completed Sep 26, 2020
@greghesp
Copy link
Author

Ah so it is! Thanks, will wait for .65

@slorber
Copy link
Collaborator

slorber commented Sep 28, 2020

thanks @lex111 👍

In the meantime you can try swizzling the DocsVersionDropdownNavbarItem component to backport the fix if you can't wait for next release

@greghesp
Copy link
Author

I did try to swizzle it, however it seems to throw errors on every attempt

Component "DocsVersionDropdownNavbarItem" doesn't exists. "DocsVersionDropdownNavbarItem" is swizzled instead of "DocsVersionDropdownNavbarItem".
Error: Component DocsVersionDropdownNavbarItem not found.No component to swizzle

@slorber
Copy link
Collaborator

slorber commented Sep 30, 2020

Thanks for reporting @greghesp , seems quite similar to #3466

@greghesp
Copy link
Author

greghesp commented Oct 3, 2020

@lex111 Did this make it into .65? I've upgraded but still not got the dropdown

@lex111
Copy link
Contributor

lex111 commented Oct 3, 2020

@greghesp is this still relevant to you? I just opened your website that uses .65 https://assistantrelay.com/, and I see that dropdown is displayed correctly. Or is it something else wrong here?

@greghesp
Copy link
Author

greghesp commented Oct 3, 2020

Ah i wonder if there was some caching or something. All looks to be working on my end now too!

@lex111
Copy link
Contributor

lex111 commented Oct 3, 2020

It may well be, I suppose. But great that this issue was resolved anyway!

@Josh-Cena Josh-Cena added closed: duplicate This issue or pull request already exists in another issue or pull request and removed status: needs triage This issue has not been triaged by maintainers labels Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution closed: duplicate This issue or pull request already exists in another issue or pull request
Projects
None yet
Development

No branches or pull requests

4 participants