docs: update windows deploy command #2281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ude a trailing whitespace after GIT_USER env variable
|
Deploy preview for docusaurus-2 ready! Built with commit b36b253 |
yangshun
added
the
pr: documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #2258, it is described that the publish script fails on Windows. The problem is caused by a whiteline that is appended to the GIT_USER env variable on windows when you run
cmd /C "set GIT_USER=<GIT_USER> && set CURRENT_BRANCH=master && set USE_SSH=true && yarn run publish-gh-pages". The same issue is also in v2, where the command iscmd /C "set GIT_USER=<GITHUB_USERNAME> && yarn deploy".We can fix the problem by using delayed expansion (surrounding
GIT_USER=<GIT_USER>with quotation marks).Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Tested locally on Windows by running the deploy command on both v1 and v2.