Skip to content

Commit

Permalink
When deploying on Windows, use delayed expansion in order to not incl…
Browse files Browse the repository at this point in the history
…ude a trailing whitespace after GIT_USER env variable
  • Loading branch information
OndrejNepozitek committed Feb 11, 2020
1 parent 311a122 commit b36b253
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion docs/getting-started-publishing.md
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ GIT_USER=<GIT_USER> \
**Windows**

```batch
cmd /C "set GIT_USER=<GIT_USER> && set CURRENT_BRANCH=master && set USE_SSH=true && yarn run publish-gh-pages"
cmd /C "set "GIT_USER=<GIT_USER>" && set CURRENT_BRANCH=master && set USE_SSH=true && yarn run publish-gh-pages"
```

There are also two optional parameters that are set as environment variables:
Expand Down
2 changes: 1 addition & 1 deletion website/docs/deployment.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ GIT_USER=<GITHUB_USERNAME> yarn deploy
**Windows**

```batch
cmd /C "set GIT_USER=<GITHUB_USERNAME> && yarn deploy"
cmd /C "set "GIT_USER=<GITHUB_USERNAME>" && yarn deploy"
```

<!--
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ GIT_USER=<GITHUB_USERNAME> yarn deploy
**Windows**

```batch
cmd /C "set GIT_USER=<GITHUB_USERNAME> && yarn deploy"
cmd /C "set "GIT_USER=<GITHUB_USERNAME>" && yarn deploy"
```

<!--
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ GIT_USER=<GITHUB_USERNAME> yarn deploy
**Windows**

```batch
cmd /C "set GIT_USER=<GITHUB_USERNAME> && yarn deploy"
cmd /C "set "GIT_USER=<GITHUB_USERNAME>" && yarn deploy"
```

<!--
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ GIT_USER=<GITHUB_USERNAME> yarn deploy
**Windows**

```batch
cmd /C "set GIT_USER=<GITHUB_USERNAME> && yarn deploy"
cmd /C "set "GIT_USER=<GITHUB_USERNAME>" && yarn deploy"
```

<!--
Expand Down

0 comments on commit b36b253

Please sign in to comment.