refactor(website): remove pure-react-carousel #10784
Merged
+79
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
the
pr: internal
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
|
Report too large to display inline |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Size Change: -11.1 kB (-0.1%) Total Size: 11.3 MB
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: -11.2 kB (-0.1%) Total Size: 11.7 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
On our v2 release blog post we have image carousels:
https://docusaurus.io/blog/2022/08/01/announcing-docusaurus-2.0
The implementation depends on a
react-pure-carousellib that is only used on this single page.This is causing troubles in our CI when trying to upgrade to React 19
(see express-labs/pure-react-carousel#476)
So I'm getting rid of the library in favor of a simpler custom carousel implementation.
This is a website-only refactor that doesn't affect any Docusaurus user apart us. Also this page is old and does not really receive traffic so it's not a big deal if the new carousel is not perfect. We only keep it for historical reasons.
Test Plan
preview
Test links
https://deploy-preview-10784--docusaurus-2.netlify.app/blog/2022/08/01/announcing-docusaurus-2.0
Related issues/PRs
Failing React 19 upgrade PR when building with
--devflag: #10763