Add missing properties to Shell related controls #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimLariviere
commented
Jun 10, 2019
| "name": "QueryChanged", | ||
| "defaultValue": "ignore", | ||
| "modelType": "string * string -> unit", | ||
| "updateCode": "(fun _ curr (target: Xamarin.Forms.SearchHandler) -> match curr with ValueSome fn -> (target :?> Fabulous.DynamicViews.CustomSearchHandler).QueryChanged <- fn | ValueNone -> ())" |
There was a problem hiding this comment.
Those updateCode don't support incremental updates.
Will try to rework that later
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds properties to the bindings file that were missing.
Also fixes some converters.
Note: Some changes to the bindings file feel hacky.
Really would like to rework that later.