Pick up AWS credentials from ENV

[sebastiankirsch]

With various AWS authentication mechanisms already in place, one of the most basic ones is yet missing: configuring credentials via environment variables.

See https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-envvars.html

[codecov]

Codecov Report

Merging #1310 into master will increase coverage by 0.13%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1310      +/-   ##
============================================
+ Coverage     56.33%   56.47%   +0.13%     
- Complexity     1798     1805       +7     
============================================
  Files           157      157              
  Lines          8547     8560      +13     
  Branches       1314     1317       +3     
============================================
+ Hits           4815     4834      +19     
+ Misses         3257     3254       -3     
+ Partials        475      472       -3

Impacted Files	Coverage Δ	Complexity Δ
...o/fabric8/maven/docker/util/AuthConfigFactory.java	71.62% <100%> (+3.51%)	80 <3> (+7)	⬆️

[rohanKanojia]

Looks good. Thanks a lot!

Could you please add some documentation also about this change and update doc/changelog.md?

[sebastiankirsch]

I've adapted the changelog and also the documentation of the Extended Authentication.
Thanks for the hint!

[rohanKanojia]

@sebastiankirsch : Np, Let's wait for Roland to review.

[sebastiankirsch]

@rhuss I gave this some more thought and realized that there are also Named Profiles that people might use to authenticate against AWS.
As an alternative to this PR and all the other AWS authentication mechanisms in the AuthConfigFactory, one could include the com.amazonaws:aws-java-sdk-core library and simply use the DefaultAWSCredentialsProviderChain. This would come with a noticeable dependency chain though...

[rhuss]

Sorry for the delay, year-end-stress here. For using the AWS support directly: What's about making this optional ? E.g. when the plugin is configured manually to use this dependency (within a <plugin><dependencies> section), then the SDK support would be used ? We could just a lookup via reflection in config factory.

wdyt ?

[sebastiankirsch]

Sorry for the delay, year-end-stress here. For using the AWS support directly: What's about making this optional ? E.g. when the plugin is configured manually to use this dependency (within a <plugin><dependencies> section), then the SDK support would be used ? We could just a lookup via reflection in config factory.

wdyt ?

Good idea. It would be a breaking change though (assuming the "native" support would be dropped), not sure what your stance is on this.

[rhuss]

Good idea. It would be a breaking change though (assuming the "native" support would be dropped), not sure what your stance is on this.

I mean we could keep the current support and use it if request but not official SDK dependency has been declared.

But let's get that PR merged first, I hope I find some room until the weekend (but year-end-stress here ....)

[rhuss]

Thanks ! looks good to me