-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch AWS Credentials from AWS SDK/Environment variables #730
Fetch AWS Credentials from AWS SDK/Environment variables #730
Conversation
91cf841
to
94327cf
Compare
Codecov Report
@@ Coverage Diff @@
## master #730 +/- ##
============================================
+ Coverage 45.09% 45.29% +0.19%
- Complexity 3139 3164 +25
============================================
Files 413 415 +2
Lines 19676 19809 +133
Branches 2765 2783 +18
============================================
+ Hits 8873 8972 +99
- Misses 9791 9823 +32
- Partials 1012 1014 +2
Continue to review full report at Codecov.
|
94327cf
to
f7ada40
Compare
kubernetes-maven-plugin/doc/src/main/asciidoc/inc/_authentication.adoc
Outdated
Show resolved
Hide resolved
jkube-kit/build/api/src/main/java/org/eclipse/jkube/kit/build/api/auth/AuthConfig.java
Outdated
Show resolved
Hide resolved
jkube-kit/build/api/src/main/java/org/eclipse/jkube/kit/build/api/auth/AuthConfig.java
Show resolved
Hide resolved
.../docker/src/main/java/org/eclipse/jkube/kit/build/service/docker/auth/AuthConfigFactory.java
Outdated
Show resolved
Hide resolved
.../docker/src/main/java/org/eclipse/jkube/kit/build/service/docker/auth/AuthConfigFactory.java
Outdated
Show resolved
Hide resolved
.../docker/src/main/java/org/eclipse/jkube/kit/build/service/docker/auth/AuthConfigFactory.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/eclipse/jkube/kit/build/service/docker/auth/ecr/AwsSdkAuthConfigFactory.java
Outdated
Show resolved
Hide resolved
...ker/src/test/java/org/eclipse/jkube/kit/build/service/docker/auth/AuthConfigFactoryTest.java
Outdated
Show resolved
Hide resolved
.../docker/src/main/java/org/eclipse/jkube/kit/build/service/docker/auth/AuthConfigFactory.java
Outdated
Show resolved
Hide resolved
.../docker/src/main/java/org/eclipse/jkube/kit/build/service/docker/auth/AuthConfigFactory.java
Outdated
Show resolved
Hide resolved
6e24f09
to
d6cbce8
Compare
jkube-kit/build/api/src/main/java/org/eclipse/jkube/kit/build/api/auth/AuthConfig.java
Outdated
Show resolved
Hide resolved
...e/docker/src/main/java/org/eclipse/jkube/kit/build/service/docker/auth/ecr/AwsSdkHelper.java
Outdated
Show resolved
Hide resolved
Add support in AuthConfigFactory to retrieve credentials from different mechanisms for AWS. Port of fabric8io/docker-maven-plugin#1311 Port of fabric8io/docker-maven-plugin#1310 Related to eclipse-jkube#702 Signed-off-by: Rohan Kumar <[email protected]>
d6cbce8
to
6ff66d1
Compare
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
Description
Add support in AuthConfigFactory to retrieve credentials from
different mechanisms for AWS.
Port of fabric8io/docker-maven-plugin#1311
Port of fabric8io/docker-maven-plugin#1310
Related to #702
Type of change
test, version modification, documentation, etc.)
Checklist