Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix busted preview-release build by forcing full ruby builds #458

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Fix busted preview-release build by forcing full ruby builds #458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e1d619
Skip ruby build caching for releases
reese Jan 26, 2024
5163633
Rollback testing stuff
reese Jan 26, 2024
b4c201b
comment
reese Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/preview-release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ env:
GEM_HOME: /tmp/.bundle
GEM_PATH: /tmp/.bundle
TERM: xterm256
FORCE_FULL_RUBY_BUILD: 1

jobs:
bump-tag:
Expand Down
3 changes: 2 additions & 1 deletion librubyfmt/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ fn main() -> Output {

// Only rerun this build if the ruby_checkout has changed
match old_checkout_sha {
Some(old_sha) if old_sha == new_checkout_sha => {}
Some(old_sha)
if old_sha == new_checkout_sha && env::var("FORCE_FULL_RUBY_BUILD").is_err() => {}
_ => {
make_configure(&ruby_checkout_path)?;
run_configure(&ruby_checkout_path)?;
Expand Down
Loading