Fix busted preview-release build by forcing full ruby builds #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reese
force-pushed
the
reese-preview-release
branch
2 times, most recently
from
d5254a4 to
8860c5b
Compare
reese
changed the title
ruby_checkout cache
reese
force-pushed
the
reese-preview-release
branch
from
87f5945 to
8860c5b
Compare
reese
force-pushed
the
reese-preview-release
branch
from
c3a9f89 to
0f233f4
Compare
reese
force-pushed
the
reese-preview-release
branch
from
0f233f4 to
6beb50a
Compare
reese
force-pushed
the
reese-preview-release
branch
from
6beb50a to
2e1d619
Compare
reese
changed the title
ruby_checkout cache
|
I forced a test build for the release and made sure it passed: https://github.com/fables-tales/rubyfmt/actions/runs/7670725309 |
fable-stripe
approved these changes
Feb 7, 2024
fables-tales
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
preview-releasebuild by removing theruby_checkoutcaching. This was causing issues with the ruby build, but removing it fixes any apparent discrepancies in the build that was causing issues. This probably makes it a bit slower, but I don't think speed is of the utmost priority since it's only run post-merge anyways 🤷I verified this works by running it on this branch: result