Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an API to reset/unset options and expose it at CLI level #1640

Merged
merged 7 commits into from
Sep 30, 2024
Merged

Add an API to reset/unset options and expose it at CLI level #1640

merged 7 commits into from
Sep 30, 2024

Conversation

Yogesh9000
Copy link
Contributor

Added an api to f3d::options to determine whether an option is optional

mwestphal
mwestphal requested changes Sep 28, 2024
View reviewed changes
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes needed, as well as testing.

@mwestphal mwestphal requested a review from Meakk September 28, 2024 18:11
@mwestphal
Copy link
Contributor

@snoyer

@codecov Codecov
Copy link

codecov bot commented Sep 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.85%. Comparing base (df8c01a) to head (f29d0f3).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1640   +/-   ##
=======================================
  Coverage   96.84%   96.85%           
=======================================
  Files         108      108           
  Lines        7673     7691   +18     
=======================================
+ Hits         7431     7449   +18     
  Misses        242      242

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mwestphal
mwestphal reviewed Sep 28, 2024
View reviewed changes
cmake/f3dOptions.cmake Outdated Show resolved Hide resolved
mwestphal
mwestphal reviewed Sep 28, 2024
View reviewed changes
library/src/options.cxx Outdated Show resolved Hide resolved
mwestphal
mwestphal requested changes Sep 28, 2024
View reviewed changes
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes needed

mwestphal
mwestphal requested changes Sep 29, 2024
View reviewed changes
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes needed

mwestphal
mwestphal reviewed Sep 29, 2024
View reviewed changes
library/src/options.cxx Outdated Show resolved Hide resolved
mwestphal
mwestphal reviewed Sep 29, 2024
View reviewed changes
library/src/options.cxx Outdated Show resolved Hide resolved
mwestphal
mwestphal requested changes Sep 29, 2024
View reviewed changes
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes needed

mwestphal
mwestphal approved these changes Sep 29, 2024
View reviewed changes
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, lets wait for @Meakk review

Meakk
Meakk approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@Meakk Meakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@Meakk Meakk merged commit ebf5575 into f3d-app:master Sep 30, 2024
39 checks passed
@Yogesh9000 Yogesh9000 deleted the feature/api-to-reset-unset-options branch September 30, 2024 19:03
@mwestphal mwestphal mentioned this pull request Nov 1, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meakk Meakk Meakk approved these changes

@mwestphal mwestphal mwestphal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yogesh9000 @mwestphal @Meakk