Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an API to reset/unset options and expose it at CLI level #1623

Open
2 of 3 tasks
mwestphal opened this issue Sep 15, 2024 · 6 comments
Open
2 of 3 tasks

Add an API to reset/unset options and expose it at CLI level #1623

mwestphal opened this issue Sep 15, 2024 · 6 comments

Comments

@mwestphal
Copy link
Contributor

mwestphal commented Sep 15, 2024

Is your feature request related to a problem? Please describe.
With the addition of optional options, some options are now unset by default.
It would be nice to be able to unset an option that have been set.
Not only at libf3d API level but also at CLI level in order to override a config file option with CLI.

Describe the solution you'd like

  • Add options::unset specific to optional options
  • Add options::reset that either unset or reset to default
  • In F3DStarter::UpdateOptions, detect "default" as a special string and in that case call options::reset instead of setAsString, also detect "N/A" as a special string and call options::unset instead of setAsString.
@mwestphal mwestphal added type:enhancement New feature or request source:libf3d help wanted Please help with this issue! source:F3DApplication labels Sep 15, 2024
@mwestphal mwestphal added this to F3D Sep 15, 2024
@mwestphal mwestphal moved this to To do in F3D Sep 15, 2024
@Yogesh9000
Copy link
Contributor

Is this issue still open? If yes I would like to work on it.

@mwestphal
Copy link
Contributor Author

done partially in #1640

@mwestphal
Copy link
Contributor Author

@Yogesh9000 wanna finish this one ?

@mwestphal
Copy link
Contributor Author

No feedback from @Yogesh9000 , unassigning

@void-inject
Copy link

i am taking this issue

@mwestphal mwestphal added this to the 3.1.0 milestone Dec 19, 2024
@mwestphal
Copy link
Contributor Author

Sorry, this issue is becoming not needed in the context of #1530

@mwestphal mwestphal removed the help wanted Please help with this issue! label Dec 19, 2024
@mwestphal mwestphal moved this from To do to Investigate in F3D Dec 19, 2024
@mwestphal mwestphal moved this from Investigate to Discuss in F3D Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Discuss
Development

No branches or pull requests

3 participants