Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ImGui support #1077

Merged
merged 10 commits into from
Nov 28, 2024
Merged

Add ImGui support #1077

merged 10 commits into from
Nov 28, 2024

Conversation

Meakk
Copy link
Member

@Meakk Meakk commented Nov 24, 2023

Add a new F3D_MODULE_UI enabling rendering UI widgets using ImGui.
Only the core library of imgui is used and a home-made VTK backend is included in this PR.

For now, only the filename widget is ported to this new framework.

@Meakk
Copy link
Member Author

Meakk commented Nov 20, 2024

Current status:

imguidemo.mp4

@Meakk Meakk marked this pull request as ready for review November 21, 2024 08:56
@Meakk Meakk changed the title imgui prototype Add ImGui support Nov 21, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 71.94093% with 133 lines in your changes missing coverage. Please review.

Project coverage is 95.69%. Comparing base (f3d7627) to head (1e5742a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
vtkext/private/module/vtkF3DImguiObserver.cxx 41.01% 128 Missing ⚠️
vtkext/private/module/vtkF3DUIActor.h 40.00% 3 Missing ⚠️
vtkext/private/module/vtkF3DUIObserver.h 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1077      +/-   ##
==========================================
- Coverage   96.97%   95.69%   -1.29%     
==========================================
  Files         110      118       +8     
  Lines        8872     9319     +447     
==========================================
+ Hits         8604     8918     +314     
- Misses        268      401     +133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Meakk Meakk mentioned this pull request Nov 26, 2024
@Meakk Meakk force-pushed the imgui2 branch 3 times, most recently from 261d012 to eab1966 Compare November 26, 2024 22:41
@Meakk Meakk requested a review from mwestphal November 26, 2024 22:56
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes needed

@Meakk Meakk requested a review from mwestphal November 27, 2024 18:50
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes needed, also I still think that doing the superbuild work in advance would be worth it to avoid nightly disruption

Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 year after PR creation, nice :)

@Meakk Meakk merged commit e2ac4dd into f3d-app:master Nov 28, 2024
38 of 40 checks passed
@Meakk Meakk deleted the imgui2 branch November 28, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants