forked from PrismarineJS/flying-squid
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.19 support #1
Open
extremeheat
wants to merge
12
commits into
18fixes
Choose a base branch
from
1.19fixes
base: 18fixes
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
1.19 support #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
extremeheat
commented
Jan 2, 2025
•
edited
Loading
edited
- Support '1.19', '1.19.2', '1.19.3', '1.19.4'
- Disable sending tablist packet as that depends on key signing and that the structure is too messy between versions (this will be fix in PC protocol updates and refactor PrismarineJS/minecraft-data#948 but will need combined changes to flying-squid and mineflayer)
- Chat signing not currently implemented, all messages from server to client are sent as system_chat messages which cannot be reported. Not important for gameplay but can be added for correctness/debugging/tab packet later
- After Pc1.19.3 add features and loginPacket PrismarineJS/minecraft-data#956
Bumps [mocha](https://github.com/mochajs/mocha) from 10.8.2 to 11.0.1. - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/main/CHANGELOG.md) - [Commits](mochajs/mocha@v10.8.2...v11.0.1) --- updated-dependencies: - dependency-name: mocha dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
please open an issue for tab and chat signing so we fix later |
* 1.18 and 1.18.2 support * test fix * wait for spawn event in tests over login * revert world sendNearbyChunks change * pchunk is updated * Add 1.18 in readme --------- Co-authored-by: Romain Beaumont <[email protected]>
merged in master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.