-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.19 #663
1.19 #663
Conversation
extremeheat
commented
Jan 4, 2025
•
edited
Loading
edited
- Support 1.19, 1.19.2, 1.19.3, 1.19.4
- Disable sending tablist packet as that depends on key signing and that the structure is too messy between versions (this will be fix in PC protocol updates and refactor minecraft-data#948 but will need combined changes to flying-squid and mineflayer)
- Chat signing not currently implemented, all messages from server to client are sent as system_chat messages which cannot be reported. Not important for gameplay but can be added for correctness/debugging/tab packet later
- After Pc1.19.3 add features and loginPacket minecraft-data#956
based on extremeheat#1 (see for details) |
@@ -175,13 +200,10 @@ module.exports.player = async function (player, serv, settings) { | |||
ping: otherPlayer._client.latency | |||
})) | |||
}) | |||
setInterval(() => player._client.write('player_info', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this is completely removed even for before 1.19 ; is this expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sends the latency for all the clients but the previous player_info packet already sends the latencies in its payload with action mode 0
Back to 1.8 https://github.com/PrismarineJS/minecraft-data/blob/master/data/pc/1.8/proto.yml#L565
I think it may have been added because it's what vanilla did at some point but it wasn't doing that for 1.17. I could re-add it behind a flag for <1.17
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
/makerelease |