Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sqlite] add config plugin #30825

Merged
merged 3 commits into from
Aug 9, 2024
Merged

[sqlite] add config plugin #30825

merged 3 commits into from
Aug 9, 2024

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Aug 5, 2024

Why

close ENG-12401

How

  • add config-plugin for expo-sqlite to support some build-time configurations
    • customBuildFlags
    • enableFTS
    • useSQLCipher
  • update doc for expo-sqlite's config-plugin

Test Plan

adding these config to apps/bare-expo/app.json, running prebuild and check the content in ios/Podfile.properties.json and android/gradle.properties

    plugins: [
      [
        "expo-sqlite",
        {
          "enableFTS": true,
          "useSQLCipher": true,
          "android": {
            "useSQLCipher": false,
            "customBuildFlags": ["-DSQLITE_ENABLE_DBSTAT_VTAB=1 -DSQLITE_ENABLE_SNAPSHOT=1"]
          },
          "ios": {
            "enableFTS": true,
            "customBuildFlags": ["-DSQLITE_ENABLE_DBSTAT_VTAB=1 -DSQLITE_ENABLE_SNAPSHOT=1"]
          }
        }
      ]
    ]

Checklist

@Kudo Kudo mentioned this pull request Aug 5, 2024
3 tasks
Copy link
Contributor Author

Kudo commented Aug 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Kudo and the rest of your teammates on Graphite Graphite

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Aug 5, 2024
Copy link

linear bot commented Aug 5, 2024

@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Aug 5, 2024
@Kudo Kudo marked this pull request as ready for review August 5, 2024 19:24
Copy link
Contributor Author

Kudo commented Aug 9, 2024

Merge activity

  • Aug 8, 10:54 PM EDT: @Kudo started a stack merge that includes this pull request via Graphite.
  • Aug 8, 10:56 PM EDT: Graphite couldn't merge this PR because it had conflicts with the trunk branch.

@Kudo Kudo changed the base branch from @kudo/sqlite-symbol-1 to graphite-base/30825 August 9, 2024 02:54
@Kudo Kudo changed the base branch from graphite-base/30825 to main August 9, 2024 02:55
@Kudo Kudo force-pushed the @kudo/sqlite-symbol-2 branch from 716b7c8 to 45ade2d Compare August 9, 2024 03:00
@Kudo Kudo merged commit 3e092b1 into main Aug 9, 2024
10 checks passed
@Kudo Kudo deleted the @kudo/sqlite-symbol-2 branch August 9, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants